Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sops filestatus should return an different JSON when creation_rules do not apply #1758

Open
red-lichtie opened this issue Feb 15, 2025 · 2 comments

Comments

@red-lichtie
Copy link

When using sops filestatus <filename> the response is either {"encrypted":true} or {"encrypted":false}.

There is no indication as to whether or not it would have an encryption applied or not based on creation_rules defined in .sops.yaml.

If the file is not encrypted and it doesn't match any of the creation_rules then filestatus should return either an empty response {} or some other flag, e.g. {"ignored":true}.

This would make linting extremely easy and not require an external function trying to emulate the sops logic.

@felixfontein
Copy link
Contributor

If the file is not encrypted, encrypted should always be false. Not returning that would be a breaking change. Adding additional information based on .sops.yaml would be possible, but not emitting encrypted is not acceptable.

@red-lichtie
Copy link
Author

Agreed, a breaking change would be bad, then something like {"encrypted":false,"ignored":true} or {"encrypted":false,"encryption_required":false} would be a possible solution.

@red-lichtie red-lichtie changed the title sops filestatus should return an empty JSON when creation_rules do not apply sops filestatus should return an different JSON when creation_rules do not apply Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants