From a1d4314edd94b3f0af8279a9f2d582404447c4fb Mon Sep 17 00:00:00 2001 From: Dan Fuller Date: Fri, 28 Feb 2025 16:25:15 -0800 Subject: [PATCH] chore(uptime): Drop `migrated` column from `UptimeSubscription` (#86082) Actually remove the column --- migrations_lockfile.txt | 2 +- .../migrations/0028_drop_migrated_column.py | 33 +++++++++++++++++++ 2 files changed, 34 insertions(+), 1 deletion(-) create mode 100644 src/sentry/uptime/migrations/0028_drop_migrated_column.py diff --git a/migrations_lockfile.txt b/migrations_lockfile.txt index bb76b00ab09094..75103a5ec4b4e9 100644 --- a/migrations_lockfile.txt +++ b/migrations_lockfile.txt @@ -21,6 +21,6 @@ social_auth: 0002_default_auto_field tempest: 0002_make_message_type_nullable -uptime: 0027_remove_migrated_and_unique_constraint +uptime: 0028_drop_migrated_column workflow_engine: 0032_remove_data_source_query_id diff --git a/src/sentry/uptime/migrations/0028_drop_migrated_column.py b/src/sentry/uptime/migrations/0028_drop_migrated_column.py new file mode 100644 index 00000000000000..a92a709c4d8e31 --- /dev/null +++ b/src/sentry/uptime/migrations/0028_drop_migrated_column.py @@ -0,0 +1,33 @@ +# Generated by Django 5.1.5 on 2025-02-27 23:17 + +from sentry.new_migrations.migrations import CheckedMigration +from sentry.new_migrations.monkey.fields import SafeRemoveField +from sentry.new_migrations.monkey.state import DeletionAction + + +class Migration(CheckedMigration): + # This flag is used to mark that a migration shouldn't be automatically run in production. + # This should only be used for operations where it's safe to run the migration after your + # code has deployed. So this should not be used for most operations that alter the schema + # of a table. + # Here are some things that make sense to mark as post deployment: + # - Large data migrations. Typically we want these to be run manually so that they can be + # monitored and not block the deploy for a long period of time while they run. + # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to + # run this outside deployments so that we don't block them. Note that while adding an index + # is a schema change, it's completely safe to run the operation after the code has deployed. + # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment + + is_post_deployment = False + + dependencies = [ + ("uptime", "0027_remove_migrated_and_unique_constraint"), + ] + + operations = [ + SafeRemoveField( + model_name="uptimesubscription", + name="migrated", + deletion_action=DeletionAction.DELETE, + ), + ]