Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove start_span(sampled=x) in POTel #4200

Closed
sentrivana opened this issue Mar 25, 2025 · 1 comment · Fixed by #4201
Closed

Remove start_span(sampled=x) in POTel #4200

sentrivana opened this issue Mar 25, 2025 · 1 comment · Fixed by #4201
Assignees
@sentrivana
Labels
Project: POTel: before alpha Project: POTel

Comments

@sentrivana
Copy link
Contributor

sentrivana commented Mar 25, 2025 •
edited
Loading

We explicitly don't want this (on child spans) because of extrapolation

But also, we can just remove this to have a smaller API surface
@sentrivana sentrivana changed the title Remove start_span(sampled=x) Remove start_span(sampled=x) in POTel Mar 25, 2025
@sentrivana sentrivana mentioned this issue Mar 25, 2025
Merged
@sentrivana sentrivana linked a pull request Apr 4, 2025 that will close this issue
chore: Make start_span fail if unsupported args are provided #4201
Merged
sentrivana added a commit that referenced this issue Apr 9, 2025
@sentrivana
chore: Make start_span fail if unsupported args are provided (#4201)
9e48965 
Make the `Span` constructor actually fail if it gets unsupported
arguments, as opposed to silently ignoring them, so that folks get
notified early.

Deprecating some of these in
#4244

Closes #4200
@sentrivana
Copy link
Contributor Author

Keeping sampled around for now to have fewer barriers when upgrading.

@sentrivana sentrivana closed this as not planned Won't fix, can't repro, duplicate, stale Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sentrivana sentrivana

Labels
Project: POTel: before alpha Project: POTel
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Make start_span fail if unsupported args are provided getsentry/sentry-python
2 participants
@stephanie-anderson @sentrivana