Calling std::abort() yields unusable stacktrace in Windows 10 Release builds

[hugoam]

Description

Calling std::abort() yields unusable stacktrace in Windows 10 Release builds

When does the problem happen

• During build
• During run-time
• When capturing a hard crash

Environment

• OS: Windows 10, 64-bit
• Compiler: MSVC 19
• Sentry-native version: 0.7.16
• MSVC Runtime Library: /MD
• MSVC Debug Info: /DEBUG
• MSVC Optimization Level: /O2 + /Ob2

Steps To Reproduce

    sentry_options_t *options = sentry_options_new();
    sentry_options_set_dsn(options, /* ... */);
    sentry_options_set_release(options, /* ... */);
    sentry_options_set_debug(options, 1);
    sentry_init(options);

    std::abort();

When run in Release build, this code yields a mostly unusable and seemingly incorrect stack trace:

The same code with throw std::runtime_error("abort") instead of std::abort() yields a usable stack trace:

In Debug build, both types of errors yield a usable stack trace

Our Runtime Library flag is /MD in the Release build and /MDd in Debug build

Log output

[sentry] INFO using database path "D:\dev\wdland2\build-release\Release\.sentry-native"
[sentry] DEBUG starting transport
[sentry] DEBUG starting background worker thread
[sentry] DEBUG starting backend
[sentry] DEBUG background worker thread started
[sentry] DEBUG starting crashpad backend with handler "D:\dev\wdland2\build-release\Release\crashpad_handler.exe"
[sentry] DEBUG using minidump URL "[...]"
[sentry] WARN crashpad WER handler module not found
[sentry] INFO started crashpad client handler
[sentry] DEBUG processing and pruning old runs
[sentry] DEBUG sending envelope
[sentry] DEBUG submitting task to background worker thread
[sentry] DEBUG executing task on worker thread
[sentry] DEBUG sending request using winhttp to "[...]"
x-sentry-auth:Sentry sentry_key=[...] sentry_version=7, sentry_client=sentry.native/0.7.16
content-type:application/x-sentry-envelope
content-length:0

[sentry] INFO flushing session and queue before crashpad handler
[sentry] DEBUG sending envelope
[sentry] DEBUG dumped 1 in-flight envelopes to disk
[sentry] INFO handing control over to crashpad

[supervacuus]

An abort() on Windows by-passes SEH, which is why crashpad registers a SIGABRT signal handler to be able to capture it. This will lead to backtraces that might include frames of the sentry library, which you should upload as part of your debug information files. These are missing in the "incorrect" stack trace. If you upload them, our backend should be able to stack-walk your backtrace.

[getsantry]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀