From 616d6b3ad5ec8740ca164886aa2ce95d6855c40c Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Fri, 31 Jan 2025 13:17:05 +0100 Subject: [PATCH 1/6] test: Skip node-profiling tests up for clarity --- .../.gitignore | 0 .../.npmrc | 0 .../build-cjs.mjs | 0 .../index.ts | 0 .../node-profiling-cjs/package.json | 21 +++++++++++++++++++ .../tsconfig.json | 0 .../node-profiling-electron/.gitignore | 1 + .../node-profiling-electron/.npmrc | 2 ++ .../__tests__/electron.spec.js | 0 .../node-profiling-electron/build-cjs.mjs | 20 ++++++++++++++++++ .../index.electron.js | 0 .../index.html | 0 .../node-profiling-electron/index.ts | 15 +++++++++++++ .../package.json | 12 ++++------- .../node-profiling-electron/tsconfig.json | 13 ++++++++++++ .../node-profiling-esm/.gitignore | 1 + .../node-profiling-esm/.npmrc | 2 ++ .../build-esm.mjs | 0 .../node-profiling-esm/index.ts | 15 +++++++++++++ .../node-profiling-esm/package.json | 21 +++++++++++++++++++ .../node-profiling-esm/tsconfig.json | 13 ++++++++++++ 21 files changed, 128 insertions(+), 8 deletions(-) rename dev-packages/e2e-tests/test-applications/{node-profiling => node-profiling-cjs}/.gitignore (100%) rename dev-packages/e2e-tests/test-applications/{node-profiling => node-profiling-cjs}/.npmrc (100%) rename dev-packages/e2e-tests/test-applications/{node-profiling => node-profiling-cjs}/build-cjs.mjs (100%) rename dev-packages/e2e-tests/test-applications/{node-profiling => node-profiling-cjs}/index.ts (100%) create mode 100644 dev-packages/e2e-tests/test-applications/node-profiling-cjs/package.json rename dev-packages/e2e-tests/test-applications/{node-profiling => node-profiling-cjs}/tsconfig.json (100%) create mode 100644 dev-packages/e2e-tests/test-applications/node-profiling-electron/.gitignore create mode 100644 dev-packages/e2e-tests/test-applications/node-profiling-electron/.npmrc rename dev-packages/e2e-tests/test-applications/{node-profiling => node-profiling-electron}/__tests__/electron.spec.js (100%) create mode 100644 dev-packages/e2e-tests/test-applications/node-profiling-electron/build-cjs.mjs rename dev-packages/e2e-tests/test-applications/{node-profiling => node-profiling-electron}/index.electron.js (100%) rename dev-packages/e2e-tests/test-applications/{node-profiling => node-profiling-electron}/index.html (100%) create mode 100644 dev-packages/e2e-tests/test-applications/node-profiling-electron/index.ts rename dev-packages/e2e-tests/test-applications/{node-profiling => node-profiling-electron}/package.json (50%) create mode 100644 dev-packages/e2e-tests/test-applications/node-profiling-electron/tsconfig.json create mode 100644 dev-packages/e2e-tests/test-applications/node-profiling-esm/.gitignore create mode 100644 dev-packages/e2e-tests/test-applications/node-profiling-esm/.npmrc rename dev-packages/e2e-tests/test-applications/{node-profiling => node-profiling-esm}/build-esm.mjs (100%) create mode 100644 dev-packages/e2e-tests/test-applications/node-profiling-esm/index.ts create mode 100644 dev-packages/e2e-tests/test-applications/node-profiling-esm/package.json create mode 100644 dev-packages/e2e-tests/test-applications/node-profiling-esm/tsconfig.json diff --git a/dev-packages/e2e-tests/test-applications/node-profiling/.gitignore b/dev-packages/e2e-tests/test-applications/node-profiling-cjs/.gitignore similarity index 100% rename from dev-packages/e2e-tests/test-applications/node-profiling/.gitignore rename to dev-packages/e2e-tests/test-applications/node-profiling-cjs/.gitignore diff --git a/dev-packages/e2e-tests/test-applications/node-profiling/.npmrc b/dev-packages/e2e-tests/test-applications/node-profiling-cjs/.npmrc similarity index 100% rename from dev-packages/e2e-tests/test-applications/node-profiling/.npmrc rename to dev-packages/e2e-tests/test-applications/node-profiling-cjs/.npmrc diff --git a/dev-packages/e2e-tests/test-applications/node-profiling/build-cjs.mjs b/dev-packages/e2e-tests/test-applications/node-profiling-cjs/build-cjs.mjs similarity index 100% rename from dev-packages/e2e-tests/test-applications/node-profiling/build-cjs.mjs rename to dev-packages/e2e-tests/test-applications/node-profiling-cjs/build-cjs.mjs diff --git a/dev-packages/e2e-tests/test-applications/node-profiling/index.ts b/dev-packages/e2e-tests/test-applications/node-profiling-cjs/index.ts similarity index 100% rename from dev-packages/e2e-tests/test-applications/node-profiling/index.ts rename to dev-packages/e2e-tests/test-applications/node-profiling-cjs/index.ts diff --git a/dev-packages/e2e-tests/test-applications/node-profiling-cjs/package.json b/dev-packages/e2e-tests/test-applications/node-profiling-cjs/package.json new file mode 100644 index 000000000000..af4d5281a3c3 --- /dev/null +++ b/dev-packages/e2e-tests/test-applications/node-profiling-cjs/package.json @@ -0,0 +1,21 @@ +{ + "name": "node-profiling-cjs", + "version": "1.0.0", + "private": true, + "scripts": { + "typecheck": "tsc --noEmit", + "test": "node dist/cjs/index.mjs", + "clean": "npx rimraf node_modules dist", + "test:build": "node build-cjs.mjs", + "test:assert": "pnpm run typecheck && pnpm run test" + }, + "dependencies": { + "@playwright/test": "~1.50.0", + "@sentry/node": "latest || *", + "@sentry/profiling-node": "latest || *", + "esbuild": "0.20.0" + }, + "volta": { + "extends": "../../package.json" + } +} diff --git a/dev-packages/e2e-tests/test-applications/node-profiling/tsconfig.json b/dev-packages/e2e-tests/test-applications/node-profiling-cjs/tsconfig.json similarity index 100% rename from dev-packages/e2e-tests/test-applications/node-profiling/tsconfig.json rename to dev-packages/e2e-tests/test-applications/node-profiling-cjs/tsconfig.json diff --git a/dev-packages/e2e-tests/test-applications/node-profiling-electron/.gitignore b/dev-packages/e2e-tests/test-applications/node-profiling-electron/.gitignore new file mode 100644 index 000000000000..1521c8b7652b --- /dev/null +++ b/dev-packages/e2e-tests/test-applications/node-profiling-electron/.gitignore @@ -0,0 +1 @@ +dist diff --git a/dev-packages/e2e-tests/test-applications/node-profiling-electron/.npmrc b/dev-packages/e2e-tests/test-applications/node-profiling-electron/.npmrc new file mode 100644 index 000000000000..949fbddc2343 --- /dev/null +++ b/dev-packages/e2e-tests/test-applications/node-profiling-electron/.npmrc @@ -0,0 +1,2 @@ +# @sentry:registry=http://127.0.0.1:4873 +# @sentry-internal:registry=http://127.0.0.1:4873 diff --git a/dev-packages/e2e-tests/test-applications/node-profiling/__tests__/electron.spec.js b/dev-packages/e2e-tests/test-applications/node-profiling-electron/__tests__/electron.spec.js similarity index 100% rename from dev-packages/e2e-tests/test-applications/node-profiling/__tests__/electron.spec.js rename to dev-packages/e2e-tests/test-applications/node-profiling-electron/__tests__/electron.spec.js diff --git a/dev-packages/e2e-tests/test-applications/node-profiling-electron/build-cjs.mjs b/dev-packages/e2e-tests/test-applications/node-profiling-electron/build-cjs.mjs new file mode 100644 index 000000000000..4a9aa83d0eec --- /dev/null +++ b/dev-packages/e2e-tests/test-applications/node-profiling-electron/build-cjs.mjs @@ -0,0 +1,20 @@ +// Because bundlers can now predetermine a static set of binaries we need to ensure those binaries +// actually exists, else we risk a compile time error when bundling the package. This could happen +// if we added a new binary in cpu_profiler.ts, but forgot to prebuild binaries for it. Because CI +// only runs integration and unit tests, this change would be missed and could end up in a release. +// Therefor, once all binaries are precompiled in CI and tests pass, run esbuild with bundle:true +// which will copy all binaries to the outfile folder and throw if any of them are missing. +import esbuild from 'esbuild'; + +console.log('Running build using esbuild version', esbuild.version); + +esbuild.buildSync({ + platform: 'node', + entryPoints: ['./index.ts'], + outfile: './dist/cjs/index.js', + target: 'esnext', + format: 'cjs', + bundle: true, + loader: { '.node': 'copy' }, + external: ['@sentry/node', '@sentry/profiling-node'], +}); diff --git a/dev-packages/e2e-tests/test-applications/node-profiling/index.electron.js b/dev-packages/e2e-tests/test-applications/node-profiling-electron/index.electron.js similarity index 100% rename from dev-packages/e2e-tests/test-applications/node-profiling/index.electron.js rename to dev-packages/e2e-tests/test-applications/node-profiling-electron/index.electron.js diff --git a/dev-packages/e2e-tests/test-applications/node-profiling/index.html b/dev-packages/e2e-tests/test-applications/node-profiling-electron/index.html similarity index 100% rename from dev-packages/e2e-tests/test-applications/node-profiling/index.html rename to dev-packages/e2e-tests/test-applications/node-profiling-electron/index.html diff --git a/dev-packages/e2e-tests/test-applications/node-profiling-electron/index.ts b/dev-packages/e2e-tests/test-applications/node-profiling-electron/index.ts new file mode 100644 index 000000000000..e956a1d9de33 --- /dev/null +++ b/dev-packages/e2e-tests/test-applications/node-profiling-electron/index.ts @@ -0,0 +1,15 @@ +import * as Sentry from '@sentry/node'; +import { nodeProfilingIntegration } from '@sentry/profiling-node'; + +const wait = (ms: number) => new Promise(resolve => setTimeout(resolve, ms)); + +Sentry.init({ + dsn: 'https://7fa19397baaf433f919fbe02228d5470@o1137848.ingest.sentry.io/6625302', + integrations: [nodeProfilingIntegration()], + tracesSampleRate: 1.0, + profilesSampleRate: 1.0, +}); + +Sentry.startSpan({ name: 'Precompile test' }, async () => { + await wait(500); +}); diff --git a/dev-packages/e2e-tests/test-applications/node-profiling/package.json b/dev-packages/e2e-tests/test-applications/node-profiling-electron/package.json similarity index 50% rename from dev-packages/e2e-tests/test-applications/node-profiling/package.json rename to dev-packages/e2e-tests/test-applications/node-profiling-electron/package.json index c48ab9c3d42d..3639432ee01a 100644 --- a/dev-packages/e2e-tests/test-applications/node-profiling/package.json +++ b/dev-packages/e2e-tests/test-applications/node-profiling-electron/package.json @@ -1,15 +1,11 @@ { - "name": "node-profiling", + "name": "node-profiling-electron", "version": "1.0.0", "private": true, "scripts": { - "typecheck": "tsc --noEmit", - "build": "node build-cjs.mjs && node build-esm.mjs", - "test": "node dist/cjs/index.js && node --experimental-require-module dist/cjs/index.js && node dist/esm/index.mjs", "clean": "npx rimraf node_modules dist", - "test:electron": "$(pnpm bin)/electron-rebuild && playwright test", - "test:build": "pnpm run typecheck && pnpm run build", - "test:assert": "pnpm run test && pnpm run test:electron" + "test:build": "node build-cjs.mjs && $(pnpm bin)/electron-rebuild", + "test:assert": "playwright test" }, "dependencies": { "@electron/rebuild": "^3.7.0", @@ -24,6 +20,6 @@ "extends": "../../package.json" }, "sentryTest": { - "skip": true + "optional": true } } diff --git a/dev-packages/e2e-tests/test-applications/node-profiling-electron/tsconfig.json b/dev-packages/e2e-tests/test-applications/node-profiling-electron/tsconfig.json new file mode 100644 index 000000000000..1308ed76609c --- /dev/null +++ b/dev-packages/e2e-tests/test-applications/node-profiling-electron/tsconfig.json @@ -0,0 +1,13 @@ +{ + "compilerOptions": { + "types": ["node"], + "esModuleInterop": true, + "lib": ["es2018"], + "strict": true, + "outDir": "dist", + "target": "ESNext", + "moduleResolution": "node", + "skipLibCheck": true + }, + "include": ["index.ts"] +} diff --git a/dev-packages/e2e-tests/test-applications/node-profiling-esm/.gitignore b/dev-packages/e2e-tests/test-applications/node-profiling-esm/.gitignore new file mode 100644 index 000000000000..1521c8b7652b --- /dev/null +++ b/dev-packages/e2e-tests/test-applications/node-profiling-esm/.gitignore @@ -0,0 +1 @@ +dist diff --git a/dev-packages/e2e-tests/test-applications/node-profiling-esm/.npmrc b/dev-packages/e2e-tests/test-applications/node-profiling-esm/.npmrc new file mode 100644 index 000000000000..949fbddc2343 --- /dev/null +++ b/dev-packages/e2e-tests/test-applications/node-profiling-esm/.npmrc @@ -0,0 +1,2 @@ +# @sentry:registry=http://127.0.0.1:4873 +# @sentry-internal:registry=http://127.0.0.1:4873 diff --git a/dev-packages/e2e-tests/test-applications/node-profiling/build-esm.mjs b/dev-packages/e2e-tests/test-applications/node-profiling-esm/build-esm.mjs similarity index 100% rename from dev-packages/e2e-tests/test-applications/node-profiling/build-esm.mjs rename to dev-packages/e2e-tests/test-applications/node-profiling-esm/build-esm.mjs diff --git a/dev-packages/e2e-tests/test-applications/node-profiling-esm/index.ts b/dev-packages/e2e-tests/test-applications/node-profiling-esm/index.ts new file mode 100644 index 000000000000..e956a1d9de33 --- /dev/null +++ b/dev-packages/e2e-tests/test-applications/node-profiling-esm/index.ts @@ -0,0 +1,15 @@ +import * as Sentry from '@sentry/node'; +import { nodeProfilingIntegration } from '@sentry/profiling-node'; + +const wait = (ms: number) => new Promise(resolve => setTimeout(resolve, ms)); + +Sentry.init({ + dsn: 'https://7fa19397baaf433f919fbe02228d5470@o1137848.ingest.sentry.io/6625302', + integrations: [nodeProfilingIntegration()], + tracesSampleRate: 1.0, + profilesSampleRate: 1.0, +}); + +Sentry.startSpan({ name: 'Precompile test' }, async () => { + await wait(500); +}); diff --git a/dev-packages/e2e-tests/test-applications/node-profiling-esm/package.json b/dev-packages/e2e-tests/test-applications/node-profiling-esm/package.json new file mode 100644 index 000000000000..79a1b880ccad --- /dev/null +++ b/dev-packages/e2e-tests/test-applications/node-profiling-esm/package.json @@ -0,0 +1,21 @@ +{ + "name": "node-profiling-esm", + "version": "1.0.0", + "private": true, + "scripts": { + "typecheck": "tsc --noEmit", + "test": "node dist/esm/index.mjs", + "clean": "npx rimraf node_modules dist", + "test:build": "node build-esm.mjs", + "test:assert": "pnpm run typecheck && pnpm run test" + }, + "dependencies": { + "@playwright/test": "~1.50.0", + "@sentry/node": "latest || *", + "@sentry/profiling-node": "latest || *", + "esbuild": "0.20.0" + }, + "volta": { + "extends": "../../package.json" + } +} diff --git a/dev-packages/e2e-tests/test-applications/node-profiling-esm/tsconfig.json b/dev-packages/e2e-tests/test-applications/node-profiling-esm/tsconfig.json new file mode 100644 index 000000000000..1308ed76609c --- /dev/null +++ b/dev-packages/e2e-tests/test-applications/node-profiling-esm/tsconfig.json @@ -0,0 +1,13 @@ +{ + "compilerOptions": { + "types": ["node"], + "esModuleInterop": true, + "lib": ["es2018"], + "strict": true, + "outDir": "dist", + "target": "ESNext", + "moduleResolution": "node", + "skipLibCheck": true + }, + "include": ["index.ts"] +} From e63c748f9c79932376526b106ca422be4bc07388 Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Fri, 31 Jan 2025 13:39:51 +0100 Subject: [PATCH 2/6] fix tests --- .../node-profiling-cjs/package.json | 7 ++++--- .../node-profiling-electron/build-cjs.mjs | 20 ------------------- .../node-profiling-electron/index.ts | 15 -------------- .../node-profiling-electron/package.json | 5 ++--- .../node-profiling-electron/tsconfig.json | 13 ------------ .../node-profiling-esm/package.json | 5 +++-- 6 files changed, 9 insertions(+), 56 deletions(-) delete mode 100644 dev-packages/e2e-tests/test-applications/node-profiling-electron/build-cjs.mjs delete mode 100644 dev-packages/e2e-tests/test-applications/node-profiling-electron/index.ts delete mode 100644 dev-packages/e2e-tests/test-applications/node-profiling-electron/tsconfig.json diff --git a/dev-packages/e2e-tests/test-applications/node-profiling-cjs/package.json b/dev-packages/e2e-tests/test-applications/node-profiling-cjs/package.json index af4d5281a3c3..aa729a030a5d 100644 --- a/dev-packages/e2e-tests/test-applications/node-profiling-cjs/package.json +++ b/dev-packages/e2e-tests/test-applications/node-profiling-cjs/package.json @@ -4,16 +4,17 @@ "private": true, "scripts": { "typecheck": "tsc --noEmit", - "test": "node dist/cjs/index.mjs", + "test": "node dist/cjs/index.js", "clean": "npx rimraf node_modules dist", - "test:build": "node build-cjs.mjs", + "test:build": "pnpm install && node build-cjs.mjs", "test:assert": "pnpm run typecheck && pnpm run test" }, "dependencies": { "@playwright/test": "~1.50.0", "@sentry/node": "latest || *", "@sentry/profiling-node": "latest || *", - "esbuild": "0.20.0" + "esbuild": "0.20.0", + "typescript": "^5.7.3" }, "volta": { "extends": "../../package.json" diff --git a/dev-packages/e2e-tests/test-applications/node-profiling-electron/build-cjs.mjs b/dev-packages/e2e-tests/test-applications/node-profiling-electron/build-cjs.mjs deleted file mode 100644 index 4a9aa83d0eec..000000000000 --- a/dev-packages/e2e-tests/test-applications/node-profiling-electron/build-cjs.mjs +++ /dev/null @@ -1,20 +0,0 @@ -// Because bundlers can now predetermine a static set of binaries we need to ensure those binaries -// actually exists, else we risk a compile time error when bundling the package. This could happen -// if we added a new binary in cpu_profiler.ts, but forgot to prebuild binaries for it. Because CI -// only runs integration and unit tests, this change would be missed and could end up in a release. -// Therefor, once all binaries are precompiled in CI and tests pass, run esbuild with bundle:true -// which will copy all binaries to the outfile folder and throw if any of them are missing. -import esbuild from 'esbuild'; - -console.log('Running build using esbuild version', esbuild.version); - -esbuild.buildSync({ - platform: 'node', - entryPoints: ['./index.ts'], - outfile: './dist/cjs/index.js', - target: 'esnext', - format: 'cjs', - bundle: true, - loader: { '.node': 'copy' }, - external: ['@sentry/node', '@sentry/profiling-node'], -}); diff --git a/dev-packages/e2e-tests/test-applications/node-profiling-electron/index.ts b/dev-packages/e2e-tests/test-applications/node-profiling-electron/index.ts deleted file mode 100644 index e956a1d9de33..000000000000 --- a/dev-packages/e2e-tests/test-applications/node-profiling-electron/index.ts +++ /dev/null @@ -1,15 +0,0 @@ -import * as Sentry from '@sentry/node'; -import { nodeProfilingIntegration } from '@sentry/profiling-node'; - -const wait = (ms: number) => new Promise(resolve => setTimeout(resolve, ms)); - -Sentry.init({ - dsn: 'https://7fa19397baaf433f919fbe02228d5470@o1137848.ingest.sentry.io/6625302', - integrations: [nodeProfilingIntegration()], - tracesSampleRate: 1.0, - profilesSampleRate: 1.0, -}); - -Sentry.startSpan({ name: 'Precompile test' }, async () => { - await wait(500); -}); diff --git a/dev-packages/e2e-tests/test-applications/node-profiling-electron/package.json b/dev-packages/e2e-tests/test-applications/node-profiling-electron/package.json index 3639432ee01a..bf02c867971a 100644 --- a/dev-packages/e2e-tests/test-applications/node-profiling-electron/package.json +++ b/dev-packages/e2e-tests/test-applications/node-profiling-electron/package.json @@ -4,7 +4,7 @@ "private": true, "scripts": { "clean": "npx rimraf node_modules dist", - "test:build": "node build-cjs.mjs && $(pnpm bin)/electron-rebuild", + "test:build": "pnpm install && $(pnpm bin)/electron-rebuild", "test:assert": "playwright test" }, "dependencies": { @@ -13,8 +13,7 @@ "@sentry/electron": "latest || *", "@sentry/node": "latest || *", "@sentry/profiling-node": "latest || *", - "electron": "^33.2.0", - "esbuild": "0.20.0" + "electron": "^33.2.0" }, "volta": { "extends": "../../package.json" diff --git a/dev-packages/e2e-tests/test-applications/node-profiling-electron/tsconfig.json b/dev-packages/e2e-tests/test-applications/node-profiling-electron/tsconfig.json deleted file mode 100644 index 1308ed76609c..000000000000 --- a/dev-packages/e2e-tests/test-applications/node-profiling-electron/tsconfig.json +++ /dev/null @@ -1,13 +0,0 @@ -{ - "compilerOptions": { - "types": ["node"], - "esModuleInterop": true, - "lib": ["es2018"], - "strict": true, - "outDir": "dist", - "target": "ESNext", - "moduleResolution": "node", - "skipLibCheck": true - }, - "include": ["index.ts"] -} diff --git a/dev-packages/e2e-tests/test-applications/node-profiling-esm/package.json b/dev-packages/e2e-tests/test-applications/node-profiling-esm/package.json index 79a1b880ccad..b633df2df172 100644 --- a/dev-packages/e2e-tests/test-applications/node-profiling-esm/package.json +++ b/dev-packages/e2e-tests/test-applications/node-profiling-esm/package.json @@ -6,14 +6,15 @@ "typecheck": "tsc --noEmit", "test": "node dist/esm/index.mjs", "clean": "npx rimraf node_modules dist", - "test:build": "node build-esm.mjs", + "test:build": "pnpm install && node build-esm.mjs", "test:assert": "pnpm run typecheck && pnpm run test" }, "dependencies": { "@playwright/test": "~1.50.0", "@sentry/node": "latest || *", "@sentry/profiling-node": "latest || *", - "esbuild": "0.20.0" + "esbuild": "0.20.0", + "typescript": "^5.7.3" }, "volta": { "extends": "../../package.json" From 6b71cbf179151ff9fd43dcf624a06f05e75fb6c1 Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Fri, 31 Jan 2025 13:49:19 +0100 Subject: [PATCH 3/6] fix electron test? --- .../test-applications/node-profiling-electron/package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dev-packages/e2e-tests/test-applications/node-profiling-electron/package.json b/dev-packages/e2e-tests/test-applications/node-profiling-electron/package.json index bf02c867971a..5f468ea6ee97 100644 --- a/dev-packages/e2e-tests/test-applications/node-profiling-electron/package.json +++ b/dev-packages/e2e-tests/test-applications/node-profiling-electron/package.json @@ -4,8 +4,8 @@ "private": true, "scripts": { "clean": "npx rimraf node_modules dist", - "test:build": "pnpm install && $(pnpm bin)/electron-rebuild", - "test:assert": "playwright test" + "test:build": "pnpm install", + "test:assert": "$(pnpm bin)/electron-rebuild && pnpm run playwright test" }, "dependencies": { "@electron/rebuild": "^3.7.0", From a55574702df4094f1ba8d2a6f1b5c07110f8cfa4 Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Fri, 31 Jan 2025 14:00:52 +0100 Subject: [PATCH 4/6] really fix it now --- .../test-applications/node-profiling-electron/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev-packages/e2e-tests/test-applications/node-profiling-electron/package.json b/dev-packages/e2e-tests/test-applications/node-profiling-electron/package.json index 5f468ea6ee97..f2819974f781 100644 --- a/dev-packages/e2e-tests/test-applications/node-profiling-electron/package.json +++ b/dev-packages/e2e-tests/test-applications/node-profiling-electron/package.json @@ -5,7 +5,7 @@ "scripts": { "clean": "npx rimraf node_modules dist", "test:build": "pnpm install", - "test:assert": "$(pnpm bin)/electron-rebuild && pnpm run playwright test" + "test:assert": "$(pnpm bin)/electron-rebuild && pnpm playwright test" }, "dependencies": { "@electron/rebuild": "^3.7.0", From ee540ec4d39c4f4a62ebc853de0cf4464fb67345 Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Fri, 31 Jan 2025 15:05:08 +0100 Subject: [PATCH 5/6] fix electron on CI? --- .../node-profiling-electron/__tests__/electron.spec.js | 1 + 1 file changed, 1 insertion(+) diff --git a/dev-packages/e2e-tests/test-applications/node-profiling-electron/__tests__/electron.spec.js b/dev-packages/e2e-tests/test-applications/node-profiling-electron/__tests__/electron.spec.js index 4519220008d1..49c0666fc1f7 100644 --- a/dev-packages/e2e-tests/test-applications/node-profiling-electron/__tests__/electron.spec.js +++ b/dev-packages/e2e-tests/test-applications/node-profiling-electron/__tests__/electron.spec.js @@ -7,6 +7,7 @@ test('an h1 contains hello world"', async () => { process: { env: { ...process.env, + NODE_ENV: 'development', }, }, }); From b7f949dc9d61d1c67b9699f0e84a420d7d9875af Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Fri, 31 Jan 2025 15:18:19 +0100 Subject: [PATCH 6/6] skip electron for now --- .../test-applications/node-profiling-electron/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev-packages/e2e-tests/test-applications/node-profiling-electron/package.json b/dev-packages/e2e-tests/test-applications/node-profiling-electron/package.json index f2819974f781..dc176c847538 100644 --- a/dev-packages/e2e-tests/test-applications/node-profiling-electron/package.json +++ b/dev-packages/e2e-tests/test-applications/node-profiling-electron/package.json @@ -19,6 +19,6 @@ "extends": "../../package.json" }, "sentryTest": { - "optional": true + "skip": true } }