File tree 1 file changed +7
-5
lines changed
1 file changed +7
-5
lines changed Original file line number Diff line number Diff line change @@ -395,11 +395,13 @@ export class GithubTarget extends BaseTarget {
395
395
}
396
396
397
397
private async checksumFromUrl ( url : string ) : Promise < string > {
398
- // XXX: This is a bit hacky as we rely on two things:
399
- // 1. GitHub issuing a redirect to S3, where they store the artifacts,
400
- // or at least pass those request headers unmodified to us
401
- // 2. AWS S3 using the MD5 hash of the file for its ETag cache header
402
- // when we issue a HEAD request.
398
+ // XXX: This is a bit hacky as we rely on various things:
399
+ // 1. GitHub issuing a redirect to AWS S3.
400
+ // 2. S3 using the MD5 hash of the file for its ETag cache header.
401
+ // 3. The file being small enough to fit in memory.
402
+ //
403
+ // Note that if assets are large (5GB) assumption 2 is not correct. See
404
+ // https://github.com/getsentry/craft/issues/322#issuecomment-964303174
403
405
let response ;
404
406
try {
405
407
response = await this . github . request ( `HEAD ${ url } ` , {
You can’t perform that action at this time.
0 commit comments