Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement allowances and sites pages UX/UI improvements #2458

Closed
stackingsaunter opened this issue Jun 1, 2023 · 8 comments
Closed

Implement allowances and sites pages UX/UI improvements #2458

stackingsaunter opened this issue Jun 1, 2023 · 8 comments
Assignees
Labels
frontend All things frontend development related

Comments

@stackingsaunter
Copy link
Contributor

This issue describes improvements to allowences design and websites view design that are ready to be picked up for implementation.

Link to Figma file

General change: For more consistency, let's use "budgets", and not use "allowance" anymore (we use terms now).

List of changes per screen:

  1. On popup view of a page that has not have a budget set, there should be a link to do it instead of empty budget bar (right now). Clicking it leads to Edit Preferences modal.

  2. An icon button of that opens Edit Preferences modal should be in the corner of site box.
    image

  3. Modal has updated copy
    image

  4. Website list item now shows all data in the copy below. I also propose chan

  5. Changing "ACTIVE" badge to "BUDGET" (active is just not clear)
    image

A revamp of website page views:

  1. Logo, name and URL is on the left side
  2. Site settings button that opens Edit Preferences modal
    image
  3. Displaying info about payments, budget and permissions (badges). If budget not set, showing a link
    image
    image

Handoff

(also in Figma file)

image
image
image
image
image

@fczuardi
Copy link
Contributor

Cool, can we (@mquasar @GabrielSoga and @fczuardi ) take this one?
I have requested Figma access.

@stackingsaunter
Copy link
Contributor Author

@fczuardi of course, thanks for tackling this! You should have access already

fczuardi added a commit to Falafel-Fellows/lightning-browser-extension that referenced this issue Jun 28, 2023
@GabrielSoga
Copy link
Contributor

@stackingsaunter In the new design, how would we remove a connected site? In the current design we have an "Remove" option within the cog menu to do this, but we couldn't find it on figma

@GabrielSoga
Copy link
Contributor

@stackingsaunter the cog icon is part of bitcoin design icon set, does the new preferences icon should be there as well?

@stackingsaunter stackingsaunter added the frontend All things frontend development related label Jun 30, 2023
@stackingsaunter
Copy link
Contributor Author

stackingsaunter commented Jun 30, 2023

@GabrielSoga

For removing sites, let's add a link "Disconnect" inside the modal. Also let's change it's name to "Site Settings" (disconnecting is just more than preferences).

image

image

Screenshot 2023-06-30 at 12 57 02

Let's leave the cog icon for general settings. Here's the new icon:
Preferences

@fczuardi
Copy link
Contributor

I think we can split this issue in smaller parts: one for the popup screen and the others for the website page views, just to get the code reviews of what we already have started.

fczuardi added a commit to Falafel-Fellows/lightning-browser-extension that referenced this issue Jul 12, 2023
@GabrielSoga GabrielSoga mentioned this issue Jul 12, 2023
6 tasks
@GabrielSoga
Copy link
Contributor

PR is open for the first part of the changes (related to popup view and site preferences launcher): #2563

GabrielSoga pushed a commit to Falafel-Fellows/lightning-browser-extension that referenced this issue Aug 2, 2023
fix: getAlby#2458
Co-Authored-By: Fabricio C Zuardi <[email protected]>
Co-Authored-By: M. Quasar <[email protected]>
GabrielSoga pushed a commit to Falafel-Fellows/lightning-browser-extension that referenced this issue Aug 2, 2023
GabrielSoga pushed a commit to Falafel-Fellows/lightning-browser-extension that referenced this issue Aug 2, 2023
fix: getAlby#2458
Co-Authored-By: Fabricio C Zuardi <[email protected]>
Co-Authored-By: M. Quasar <[email protected]>
GabrielSoga added a commit to Falafel-Fellows/lightning-browser-extension that referenced this issue Aug 2, 2023
fix: getAlby#2458

Co-Authored-By: Fabricio C Zuardi <[email protected]>
Co-Authored-By: M. Quasar <[email protected]>
Co-Authored-By: GabrielSoga <[email protected]>
@GabrielSoga
Copy link
Contributor

@stackingsaunter PR #2617 is ready to review

fczuardi added a commit to Falafel-Fellows/lightning-browser-extension that referenced this issue Aug 3, 2023
fczuardi added a commit to Falafel-Fellows/lightning-browser-extension that referenced this issue Aug 3, 2023
fix: getAlby#2458

Co-Authored-By: Fabricio C Zuardi <[email protected]>
Co-Authored-By: M. Quasar <[email protected]>
Co-Authored-By: GabrielSoga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend All things frontend development related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants