Graceful fail when couldn't save an image #4

Author: MrCsabaToth

src/main/java/com/valleydevfest/androidify/PlaceholderFragment.java

@@ -176,8 +176,14 @@ private void share() {
             requireActivity().getContentResolver(), bitmap,
             getResources().getString(R.string.android_avatar), null
         );
-        Uri imageURI = Uri.parse(imagePath);
-        startShareActivity(imageURI);
+        if (imagePath == null) {
+            Toast.makeText(getActivity(),
+                    getResources().getString(R.string.could_not_save),
+                    Toast.LENGTH_SHORT).show();
+        } else {
+            Uri imageURI = Uri.parse(imagePath);
+            startShareActivity(imageURI);
+        }
     }
 
     private void startShareActivity(Uri imageURI) {

src/main/res/values/strings.xml

@@ -9,8 +9,9 @@
     <string name="figure_saved">Figure Saved!</string>
     <string name="submit">Submit to website</string>
     <string name="back_to_website">Visit website</string>
-    <string name="no_browser">Could not open browser</string>
+    <string name="no_browser">So sorry, could not open browser</string>
     <string name="share">Save / Share</string>
+    <string name="could_not_save">So sorry, could not save image</string>
     <string name="android_avatar">Android Avatar</string>
 
 </resources>