Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document "Spaces between label and colons" in rgbasm-old.5 #1601

Open
Rangi42 opened this issue Jan 5, 2025 · 2 comments · May be fixed by #1618
Open

Document "Spaces between label and colons" in rgbasm-old.5 #1601

Rangi42 opened this issue Jan 5, 2025 · 2 comments · May be fixed by #1618
Labels
docs This affects the documentation (web-specific issues go to rgbds-www) rgbasm This affects RGBASM
Milestone

Comments

@Rangi42
Copy link
Contributor

Rangi42 commented Jan 5, 2025

I thought this would count as a mere syntax bugfix, but it's turned up a couple of times (e.g. in pokegold-spaceworld and some project used to have a Label: :), so may as well document it.

(Be sure to check when we added :: as its own token.)

Also, unrelated, but the heading "LDHL, SP, e8" should be "LDHL SP, e8".

@Rangi42 Rangi42 added docs This affects the documentation (web-specific issues go to rgbds-www) rgbasm This affects RGBASM labels Jan 5, 2025
@Rangi42 Rangi42 added this to the 0.9.1 milestone Jan 5, 2025
@Rangi42 Rangi42 self-assigned this Jan 5, 2025
@Rangi42
Copy link
Contributor Author

Rangi42 commented Jan 5, 2025

Heck, maybe we should document add r16 and add sp for add hl, r16 and add hl, sp too. Or even = for set as an instruction. The line between "fixed bug" and "removed feature" is blurry, and people do whatever silly thing is technically possible. :P

@vulcandth
Copy link

Maybe I'll go around and start upgrading random RGBDS repos to 0.9.0 and document all the weird stuff people do that need to be fixed. lol.

@Rangi42 Rangi42 linked a pull request Jan 18, 2025 that will close this issue
@Rangi42 Rangi42 removed their assignment Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This affects the documentation (web-specific issues go to rgbds-www) rgbasm This affects RGBASM
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants