remove lots of unnecessary calls to getRuntimeMetamodels()

I completely understand the desire to not go to the SessionFactoryImplementor
for everything, and I'm totally onboard with that, but this isn't actually
helping at all (if there ever came a time when we needed to, we can inline
those convenience methods completely *trivially*). If we want to actually not
depend on the SFI, we need to start passing RuntimeMetamodelsImplementor around
instead. That would be *awesome* but it's probably a lot more work.

For now the value of the convenience methods is clear, it seems to me.

Author: gavinking

Diff for: hibernate-core/src/main/java/org/hibernate/action/internal/BulkOperationCleanupAction.java

@@ -111,7 +111,7 @@ public BulkOperationCleanupAction(SharedSessionContractImplementor session, Enti
 	public BulkOperationCleanupAction(SharedSessionContractImplementor session, Set<String> tableSpaces) {
 		final LinkedHashSet<String> spacesList = new LinkedHashSet<>( tableSpaces );
 
-		final MappingMetamodelImplementor metamodel = session.getFactory().getRuntimeMetamodels().getMappingMetamodel();
+		final MappingMetamodelImplementor metamodel = session.getFactory().getMappingMetamodel();
 		metamodel.forEachEntityDescriptor( (entityDescriptor) -> {
 			final String[] entitySpaces = (String[]) entityDescriptor.getQuerySpaces();
 			if ( affectedEntity( tableSpaces, entitySpaces ) ) {
@@ -143,7 +143,7 @@ public BulkOperationCleanupAction(SharedSessionContractImplementor session, Set<
 
 	public static void schedule(SharedSessionContractImplementor session, SqmDmlStatement<?> statement) {
 		final List<EntityPersister> entityPersisters = new ArrayList<>( 1 );
-		final MappingMetamodelImplementor metamodel = session.getFactory().getRuntimeMetamodels().getMappingMetamodel();
+		final MappingMetamodelImplementor metamodel = session.getFactory().getMappingMetamodel();
 		if ( !( statement instanceof InsertSelectStatement ) ) {
 			entityPersisters.add( metamodel.getEntityDescriptor( statement.getTarget().getEntityName() ) );
 		}

Diff for: hibernate-core/src/main/java/org/hibernate/action/internal/UnresolvedEntityInsertActions.java

@@ -130,11 +130,10 @@ private void logCannotResolveNonNullableTransientDependencies(SharedSessionContr
 		for ( Map.Entry<Object,Set<AbstractEntityInsertAction>> entry : dependentActionsByTransientEntity.entrySet() ) {
 			final Object transientEntity = entry.getKey();
 			final String transientEntityName = session.guessEntityName( transientEntity );
-			final Object transientEntityId = session.getFactory()
-					.getRuntimeMetamodels()
-					.getMappingMetamodel()
-					.getEntityDescriptor( transientEntityName )
-					.getIdentifier( transientEntity, session );
+			final Object transientEntityId =
+					session.getFactory().getMappingMetamodel()
+							.getEntityDescriptor( transientEntityName )
+							.getIdentifier( transientEntity, session );
 			final String transientEntityString = infoString( transientEntityName, transientEntityId );
 			final Set<String> dependentEntityStrings = new TreeSet<>();
 			final Set<String> nonNullableTransientPropertyPaths = new TreeSet<>();