You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We need to do the same with the Premium repo. We have some build code already present in the premium workflow, but the develop branch is always checked out for the free repo. This works in most cases, but if we have a more complex PR that spans both the free and premium repos, the plugin will not be built correctly.
Unhandled scenario: premium repo branch is fix/1234-some-bug that also has code adjustments in an identically named free repo branch fix/1234-some-bug
To address this, we need to check the existence of the identical branch name in the free repo, then if that's present, use that, but if not, we fall back to using develop.
We'll need to replace the current checkout logic in premium to (untested):
We've added https://github.com/gambitph/Stackable/blob/develop/.github/workflows/plugin-build.yml that builds the plugin per pull request.
We need to do the same with the Premium repo. We have some build code already present in the premium workflow, but the
develop
branch is always checked out for the free repo. This works in most cases, but if we have a more complex PR that spans both the free and premium repos, the plugin will not be built correctly.Unhandled scenario: premium repo branch is
fix/1234-some-bug
that also has code adjustments in an identically named free repo branchfix/1234-some-bug
To address this, we need to check the existence of the identical branch name in the free repo, then if that's present, use that, but if not, we fall back to using
develop
.We'll need to replace the current checkout logic in premium to (untested):
Thanks to actions/checkout#512 (comment) for the inspiration.
The text was updated successfully, but these errors were encountered: