Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Requirements mentioned #250

Open
shivergard opened this issue Oct 10, 2024 · 1 comment
Open

Incorrect Requirements mentioned #250

shivergard opened this issue Oct 10, 2024 · 1 comment

Comments

@shivergard
Copy link

Building example gave me error:

github.com/gagliardetto/solana-go/rpc/jsonrpc

../../../../../go/pkg/mod/github.com/gagliardetto/[email protected]/rpc/jsonrpc/jsonrpc.go:535:28: undefined: atomic.Uint64
note: module requires Go 1.19

As said - it looks like minimal version of Golang is not 1.18 , but 1.19++

@shivergard
Copy link
Author

The problem is :
var integerID = new(atomic.Uint64)
it is not supported in 1.18. It can be updated for
var integerID = new(uint64)
and in function newID I've changed it to:

func newID() any { if useFixedID { return defaultFixedID } if UseIntegerID { atomic.AddUint64(integerID,1) return integerID } return uuid.New().String() }

code does build on 1.18 , but not sure what it changes - so most probably you should update min Requirements in readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant