Use the localExternal when creating JSExternals

Olle Fredriksson · Olle Fredriksson · commit b08b0bd4c601 · 2016-12-16T15:47:41.000+01:00
Otherwise we might prematurely free Externals, since the object with the
finalizer has nothing to do with the object managed by the JSExternal.
diff --git a/V8Simple.cpp b/V8Simple.cpp
@@ -946,7 +946,7 @@ DllPublic JSExternal* CDecl CreateJSExternal(JSContext* context, void* value)
 		},
 		v8::WeakCallbackType::kParameter);
 
-	return new JSExternal(context->Isolate, v8::External::New(context->Isolate, value));
+	return new JSExternal(context->Isolate, localExternal);
 }
 
 DllPublic void* CDecl GetJSExternalValue(JSContext* context, JSExternal* external)

Original file line number	Diff line number	Diff line change
`@@ -946,7 +946,7 @@ DllPublic JSExternal* CDecl CreateJSExternal(JSContext* context, void* value)`
`946`	`946`	`},`
`947`	`947`	`v8::WeakCallbackType::kParameter);`
`948`	`948`
`949`		`- return new JSExternal(context->Isolate, v8::External::New(context->Isolate, value));`
	`949`	`+ return new JSExternal(context->Isolate, localExternal);`
`950`	`950`	`}`
`951`	`951`
`952`	`952`	`DllPublic void* CDecl GetJSExternalValue(JSContext* context, JSExternal* external)`