Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPath with SimpleCache (and other fsspec layers)? #345

Closed
emfdavid opened this issue Mar 14, 2025 · 1 comment
Closed

UPath with SimpleCache (and other fsspec layers)? #345

emfdavid opened this issue Mar 14, 2025 · 1 comment

Comments

@emfdavid
Copy link

UPath is amazing - this is the pattern I have been looking for!

I would like to be able to use some of the awesome url chaining options from fsspec. It seems like this should be possible... but I wonder if there is something I am missing about why you haven't done it?

I would be happy to work on it... I think it would be easiest to do modifying the existing UPath... I don't see a way to do it via a new subclass that would use other existing subclasses... but that would be cleaner if possible.
Suggestions welcome!

@ap--
Copy link
Collaborator

ap-- commented Mar 16, 2025

Hi @emfdavid

Happy to hear that you like universal-pathlib ❤ And thank you so much for offering to contribute 🙏

I wonder if there is something I am missing about why you haven't done it?

Mostly because I work on universal-pathlib in my free time and I've been extremely busy with work lately.

I think it would be easiest to do modifying the existing UPath... I don't see a way to do it via a new subclass that would use other existing subclasses...

Yes, chaining support should be added to UPath itself. There are a few special things to consider, some are mentioned in my comment here: #28 (comment)

Let's also continue discussion in issue #28 (I'll close your issue for now)

Suggestions welcome!

I have started some work on this that I will push as a draft PR is pushed here as a draft PR #346 . And I will try to add more details to the other issue asap. And I added some todos to the PR. Let me know if there are any questions!

Cheers,
Andreas 😃

@ap-- ap-- closed this as completed Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants