✨ Add KnownBadLayerLintError, use for XRNeckSafer and OpenXR Toolkit

Fixed by disablign the layer

Author: fredemmott

src/Linter.cpp

@@ -104,6 +104,28 @@ std::vector<APILayer> OrderingLintError::Fix(
   return newLayers;
 }
 
+KnownBadLayerLintError::KnownBadLayerLintError(
+  const std::string& description,
+  const std::filesystem::path& layer)
+  : FixableLintError(description, {layer}) {
+}
+
+std::vector<APILayer> KnownBadLayerLintError::Fix(
+  const std::vector<APILayer>& allLayers) {
+  const auto affected = this->GetAffectedLayers();
+  assert(affected.size() == 1);
+  const auto& path = *affected.begin();
+
+  auto newLayers = allLayers;
+  auto it = std::ranges::find_if(
+    newLayers, [&path](const auto& layer) { return layer.mJSONPath == path; });
+
+  if (it != newLayers.end()) {
+    it->mValue = APILayer::Value::Disabled;
+  }
+  return newLayers;
+}
+
 InvalidLayerLintError::InvalidLayerLintError(
   const std::string& description,
   const std::filesystem::path& layer)

src/Linter.hpp

@@ -64,7 +64,18 @@ class OrderingLintError final : public FixableLintError {
   std::filesystem::path mRelativeTo;
 };
 
-// A lint error that is fixed by removing the layer
+/// A lint error that is fixed by disabling the layer
+class KnownBadLayerLintError final : public FixableLintError {
+  public:
+    KnownBadLayerLintError(
+      const std::string& description,
+      const std::filesystem::path& layer);
+
+  ~KnownBadLayerLintError() override = default;
+  std::vector<APILayer> Fix(const std::vector<APILayer>&) override;
+};
+
+/// A lint error that is fixed by removing the layer
 class InvalidLayerLintError final : public FixableLintError {
  public:
   InvalidLayerLintError(

src/linters/windows/OpenXRToolkitLinter.cpp

@@ -29,11 +29,11 @@ class OpenXRToolkitLinter final : public Linter {
       if (details.mName != "XR_APILAYER_MBUCCHIA_toolkit") {
         continue;
       }
-      errors.push_back(std::make_shared<LintError>(
+      errors.push_back(std::make_shared<KnownBadLayerLintError>(
         "OpenXR Toolkit is unsupported, and is known to cause crashes and "
         "other issues in modern games; you should disable it if you encounter "
         "problems.",
-        PathSet { layer.mJSONPath }));
+        layer.mJSONPath));
     }
     return errors;
   }

src/linters/windows/XRNeckSaferLinter.cpp

@@ -33,11 +33,11 @@ class XRNeckSaferLinter final : public Linter {
         continue;
       }
       errors.push_back(
-        std::make_shared<LintError>(
+        std::make_shared<KnownBadLayerLintError>(
           "XRNeckSafer has bugs that can cause issues include game crashes, and "
           "crashes in other API layers. Disable or uninstall it if you have any "
           "issues.",
-          PathSet {layer.mJSONPath}));
+          layer.mJSONPath));
     }
     return errors;
   }