-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving away from lens
to provide classy optics
#101
Comments
@Kleidukos thanks for filing. I'm at end of my day but will return tomorrow and set out all the API breaks I can think of, for discussion on how to proceed, and some rough ideas about the order in which to do things. |
@Kleidukos sorry for the delay, I should manage to get to it in the next couple days. |
OK, sorry it took so long. Rough plan:
Commits should follow the plan above, more or less.
Note that use of lazy ByteString where the payload is concerned does not match with how the JWS is defined. Specifically, the payload is stored as a I probably missed some stuff and we will no doubt have more to discuss as the work gets tacked. |
@frasertweedale I can't say I'm the most comfortable with the codebase, but if you're available for some pairing one day, I would love that. :) |
After a discussion with @frasertweedale, it has been decided to explore available options to end the dependency on
lens
for the API, while still retaining the classy optics that are not moving anywhere soon.There is also a plan to get rid of TH for optics generation.
Points to discuss:
The text was updated successfully, but these errors were encountered: