Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task version sorting goes wrong for scmultiplex task #732

Closed
jluethi opened this issue Mar 14, 2025 · 4 comments · Fixed by #733
Closed

Task version sorting goes wrong for scmultiplex task #732

jluethi opened this issue Mar 14, 2025 · 4 comments · Fixed by #733

Comments

@jluethi
Copy link
Collaborator

jluethi commented Mar 14, 2025

The task version sorting needed to display the most recent task and also to decide which tasks can be updated goes wrong on the FMI server running fractal web 1.16.0, fractal-server 2.13.1 for a single package (the scmultiplex package), while it works for all other packages. I can't trace what causes this.

For the active task versions, I see:

Image

On the task management page, it includes the deactivated task versions. But it still sorts wrong:

Image

All other task packages show the correct version as most recent. Any ideas what could be going wrong here?

cc @nrepina for further hints if you have any

@jluethi
Copy link
Collaborator Author

jluethi commented Mar 14, 2025

It seems to only occur once the 0.8.6.dev1 version was added. Is there an issue with how sorting happens in the presence of such dev versions?

@tcompa
Copy link
Collaborator

tcompa commented Mar 14, 2025

Ref #286.

I guess the presence of three dots make the version invalid in semver (ref #286 (comment)), and then coerce is called. But I don't know what is the result of coerce('1.2.3.dev4').

@zonia3000
Copy link
Collaborator

We are not calling coerce in this case. I'm fixing it.

@jluethi
Copy link
Collaborator Author

jluethi commented Mar 14, 2025

I deployed this at FMI & can confirm that the issue is fixed. Thanks a lot @zonia3000 for the fast turn-around on this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants