Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle missing requirements in snforge compatibility check #2807

Closed
cptartur opened this issue Dec 20, 2024 · 0 comments · Fixed by #3111
Closed

Handle missing requirements in snforge compatibility check #2807

cptartur opened this issue Dec 20, 2024 · 0 comments · Fixed by #3111
Assignees
@ddoktorski
Labels
feature New feature request/description snforge

Comments

@cptartur
Copy link
Member

Currently, snforge compatibility check displays nice output only when incorrect version of a requirement is installed. In case it is missing entirely, Failed to run version command for {name} error is bubbled.

Update compatibility check so it displays missing requirements similarly as incompatible.
E.g. "❌ {} is not installed" or similar.
@cptartur cptartur added feature New feature request/description snforge labels Dec 20, 2024
@cptartur cptartur moved this to New in Starknet foundry Dec 20, 2024
@github-actions github-actions bot added the new label Dec 20, 2024
@cptartur cptartur moved this from New to Backlog in Starknet foundry Jan 17, 2025
@cptartur cptartur removed the new label Feb 3, 2025
@cptartur cptartur moved this from Backlog to TODO in Starknet foundry Feb 3, 2025
@cptartur cptartur mentioned this issue Feb 18, 2025
Merged
@ddoktorski ddoktorski mentioned this issue Mar 18, 2025
Merged
@ddoktorski ddoktorski moved this from TODO to In Progress in Starknet foundry Mar 19, 2025
github-merge-queue bot pushed a commit that referenced this issue Mar 24, 2025
@ddoktorski
Handle requirements check when tools not installed (#3111)
555692f 
<!-- Reference any GitHub issues resolved by this PR -->

Closes #2807 

## Introduced changes

<!-- A brief description of the changes -->

- Display a formatted message when `--version` command fails instead of
returning an immediate error
@github-project-automation github-project-automation bot moved this from In Progress to Done in Starknet foundry Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddoktorski ddoktorski

Labels
feature New feature request/description snforge
Projects
Starknet foundry
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle requirements check when tools not installed foundry-rs/starknet-foundry
3 participants
@ddoktorski @cptartur @franciszekjob