Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(releases): make the versions lex sortable #9602

Open
sambacha opened this issue Dec 29, 2024 · 2 comments
Open

feat(releases): make the versions lex sortable #9602

sambacha opened this issue Dec 29, 2024 · 2 comments
Labels
A-installer Area: installer T-feature Type: feature

Comments

@sambacha
Copy link
Contributor

Component

Forge, Cast, Anvil, Foundryup, Chisel

Describe the feature you would like

Previously I argued for this sort of scheme in #701

TZ=UTC git show --quiet --date="format-local:%Y.%-m.%-d" --format="nightly-%cd"
>> nightly-2024.2.15

Instead something like this (prefixing nightly- can be done)

git show -s "--format=%cd-%h" "--date=format:%Y%m%d-%H%M%S"
>> 20240215-124254-59fbc5a

Additional context

No response

@sambacha sambacha added T-feature Type: feature T-needs-triage Type: this issue needs to be labelled labels Dec 29, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Dec 29, 2024
@zerosnacks zerosnacks added T-post-V1 Area: to tackle after V1 A-installer Area: installer and removed T-needs-triage Type: this issue needs to be labelled labels Jan 3, 2025
@zerosnacks
Copy link
Member

Hi @sambacha

Our current reported versions look as follows:

$ forge --version
forge Version: 1.0.0-nightly
Commit SHA: 9bcfbaa6e6066fb9f87ce07163f5479d4b124563
Build Timestamp: 2025-02-26T00:21:24.429838503Z (1740529284)
Build Profile: maxperf
$ forge -V
forge 1.0.0-nightly (9bcfbaa6e6 2025-02-26T00:21:24.429838503Z)

and in the cheatcode it is

0.3.0-nightly+3cb96bde9b.1737036656.debug

Is this sufficient or is there still something missing?

Thanks!

@sambacha
Copy link
Contributor Author

Hi @sambacha

Our current reported versions look as follows:

$ forge --version
forge Version: 1.0.0-nightly
Commit SHA: 9bcfbaa6e6066fb9f87ce07163f5479d4b124563
Build Timestamp: 2025-02-26T00:21:24.429838503Z (1740529284)
Build Profile: maxperf
$ forge -V
forge 1.0.0-nightly (9bcfbaa6e6 2025-02-26T00:21:24.429838503Z)

and in the cheatcode it is

0.3.0-nightly+3cb96bde9b.1737036656.debug

Is this sufficient or is there still something missing?

Thanks!

Maybe an adjustment like this:

I think this should make the versions lex. sortable

E.g. "v2.0.0-beta.2-7-g12ab34cd56.debug*"
       ttttttttttttt N hhhhhhhhhhhDDDDDd
  t => last matching annotated tag
  N => distance (in commits) from tag
  h => git commit id (hash)
  D => Debug work tree
  d => dirty tree flag

@zerosnacks zerosnacks changed the title Change versioning once v1.0 milestone achieved. feat(releases): make the versions lex sortable Feb 27, 2025
@zerosnacks zerosnacks removed the T-post-V1 Area: to tackle after V1 label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-installer Area: installer T-feature Type: feature
Projects
Status: Todo
Development

No branches or pull requests

2 participants