Skip to content

feat(cast): include recover_authority when logging SignedAuthorization #10100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mattsse opened this issue Mar 17, 2025 · 4 comments
Open

feat(cast): include recover_authority when logging SignedAuthorization #10100

mattsse opened this issue Mar 17, 2025 · 4 comments
Labels
C-cast Command: cast first issue A good way to start contributing T-feature Type: feature

Comments

@mattsse
Copy link
Member

mattsse commented Mar 17, 2025

Component

Cast

Describe the feature you would like

this currently logs the raw signedauth object

foundry/crates/common/fmt/src/ui.rs

Line 444 in 6ce4571

self.authorization_list()

but we should also include the recover_authority() address here

TODO

  • include authority in Uifmt for SignedAuths

Additional context

No response
@mattsse mattsse added T-feature Type: feature T-needs-triage Type: this issue needs to be labelled labels Mar 17, 2025
@github-project-automation github-project-automation bot moved this to Todo in Foundry Mar 17, 2025
@mattsse mattsse added the first issue A good way to start contributing label Mar 17, 2025
@zerosnacks zerosnacks added C-cast Command: cast and removed T-needs-triage Type: this issue needs to be labelled labels Mar 17, 2025
@zerosnacks zerosnacks changed the title include recover_authority when logging SignedAuthorization feat(cast): include recover_authority when logging SignedAuthorization Mar 17, 2025
@0xMushow
Copy link
Contributor

Can I take this one please?

@mattsse
Copy link
Member Author

mattsse commented Mar 17, 2025

assigned, ty

@mattsse
Copy link
Member Author

mattsse commented Mar 17, 2025

maybe we should impl Uifmt for RecoveredAuthorization here and convert the signedauth into this

@Ayushdubey86
Copy link
Contributor

can i take over this?

@yash-atreya yash-atreya assigned Ayushdubey86 and unassigned 0xMushow Apr 9, 2025
@Ayushdubey86 Ayushdubey86 mentioned this issue Apr 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cast Command: cast first issue A good way to start contributing T-feature Type: feature
Projects
Foundry
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: print authority with authorization list Ayushdubey86/foundry
4 participants
@mattsse @Ayushdubey86 @zerosnacks @0xMushow