Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixinator 5.0.1 saying dbtype attribute of cfquery was removed in Coldfusion 11 #20

Open
wandmdave opened this issue Jan 27, 2025 · 1 comment

Comments

@wandmdave
Copy link

wandmdave commented Jan 27, 2025

I was checking out the new goals feature of fixinator on some old code I've been assigned to clean up using the following command:
box fixinator path=mypath goals=compatibility engines=adobe@2023

Among the results that it returns is the result below:
[HIGH] Adobe ColdFusion Compatibility finding on line 95 of programReport.cfm high confidence
The dbtype attribute of the cfquery tag was removed in ColdFusion 11
/reporting/programReport.cfm:95
95: <cfquery name="Program_Objectives" dbtype="query">

Here is the code in question:
line 95:

<cfquery name="Program_Objectives" dbtype="query">
            	select * from getResults
                where OBJECTIVEID = '#getObjectives.objectiveID#' and Program = '#getProgram.program#' 
</cfquery>

getResults is the name of a previous query.

When I look up cfquery in the coldfusion reference page (https://helpx.adobe.com/coldfusion/cfml-reference/coldfusion-tags/tags-p-q/cfquery.html) it still lists dbtype as an available attribute. The history mentions all other acceptable values being removed except "query" but not dbtype itself.

Apologies if I'm missing something silly. I'm pretty new to Coldfusion and Fixinator.

@pfreitag
Copy link
Member

Thanks for reporting that - it should not be flagging dbtype="query" there were a few dbtypes that were removed, but query should be fine - I will look into this further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants