Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request for feedback: Proposal of reorganization of profiles #4801

Open
felipesanches opened this issue Jul 17, 2024 · 2 comments
Open

Request for feedback: Proposal of reorganization of profiles #4801

felipesanches opened this issue Jul 17, 2024 · 2 comments
Assignees
@felipesanches
Milestone
0.13.0

Comments

@felipesanches
Copy link
Collaborator

Currently we have these profiles:

  • adobefonts
  • fontbureau
  • fontval
  • fontwerk
  • googlefonts
  • iso15008
  • microsoft
  • notofonts
  • opentype
  • outline
  • shaping
  • typenetwork
  • ufo
  • universal

We can categorize them this way:

Generaly useful ones:

  • Universal - Universally adopted QA criteria.
  • OpenType - Things required by the spec
  • iso15008 - Another industry standard, but not necessarily used by everyone.

Vendor specific profiles:

  • adobefonts
  • fontbureau
  • fontwerk
  • googlefonts
  • microsoft
  • typenetwork

Profile defined by file-type:

  • ufo - checks for Unified Font Object files.

Profiles defined by aspect of problems being checked for:

  • outline - Glyph outline characteristics
  • shaping - Problems related to font shaping.

outliers:

  • fontval - a wrapper around a 3rd party QA tool (originally what one could call the "Microsoft" profile)
  • notofonts - project-specific QA criteria (sort of "GoogleFonts" profile)

I think that we should reorganize the profiles to be categorized strictly by vendor needs. It means that we should fit everything into either "Generaly useful profiles" or "Vendor specific profiles".

So, for instance, UFO checks should be assigned to either vendor-specific profiles or to the Universal one.
Same reasoning for shaping and outline.

Maybe we should drop support for fontval. Or, maybe, the check could be included in the Microsoft profile.

I think it won't be too hard to include notofonts related checks in the GoogleFonts profile and simply check Noto families with the GFonts profile.

The only one here that I am still a bit uncertain is the iso15008 one. Not sure if we should have a special way to enable/disable that kind of profile, as it definitely does not apply to all font families (so it can't be considered universal), but it is also not vendor-specific. This one sounds legitimately optional.
@davelab6
Copy link
Contributor

Broadly I support this work

@davelab6 davelab6 mentioned this issue Jul 19, 2024
Open
@felipesanches felipesanches mentioned this issue Aug 8, 2024
Merged
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Aug 8, 2024
@felipesanches
These checks are not included in any profile... Must be fixed later.
468bdce 
(issue fonttools#4801 & PR fonttools#4809)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Aug 8, 2024
@felipesanches
These checks are not included in any profile... Must be fixed later.
2ae3e07 
(issue fonttools#4801 & PR fonttools#4809)
felipesanches added a commit that referenced this issue Aug 8, 2024
@felipesanches
These checks are not included in any profile... Must be fixed later.
b17ab14 
(issue #4801 & PR #4809)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Aug 9, 2024
@felipesanches
Deprecation of UFO profile, and migration of its checks
228e8e8 
The UFO profile was removed and its checks were migrated to the Universal profile.
For that reason, all of them received a temporary "experimental" flag.

Those checks will only run when actual UFO projects are passed to fontbakery.

(issue fonttools#4801)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Aug 9, 2024
@felipesanches
Deprecation of Shaping profile, and migration of its checks
b441e62 
The Shaping profile was also removed and its checks migrated to the Google Fonts profile.
As gfonts was already including those, and no other profile did so, there's no need to add experimental flags to these ones.

(issue fonttools#4801)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Aug 9, 2024
@felipesanches
Deprecation of Outline profile, and migration of its checks
7fc0706 
The Outline profile was also removed and its checks migrated to the Google Fonts profile.
As gfonts was already including those, and no other profile did so, there's no need to add experimental flags to these ones.

(issue fonttools#4801)
@felipesanches felipesanches added this to the 0.12.10 milestone Aug 9, 2024
@felipesanches felipesanches self-assigned this Aug 9, 2024
@felipesanches felipesanches mentioned this issue Aug 9, 2024
Merged
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Aug 9, 2024
@felipesanches
Deprecation of Outline profile, and migration of its checks
42f8be7 
The Outline profile was also removed and its checks migrated to the Google Fonts profile.
As gfonts was already including those, and no other profile did so, there's no need to add experimental flags to these ones.

(issue fonttools#4801)
felipesanches added a commit that referenced this issue Aug 9, 2024
@felipesanches
Deprecation of UFO profile, and migration of its checks
69bc6ff 
The UFO profile was removed and its checks were migrated to the Universal profile.
For that reason, all of them received a temporary "experimental" flag.

Those checks will only run when actual UFO projects are passed to fontbakery.

(issue #4801)
felipesanches added a commit that referenced this issue Aug 9, 2024
@felipesanches
Deprecation of Shaping profile, and migration of its checks
3f64daa 
The Shaping profile was also removed and its checks migrated to the Google Fonts profile.
As gfonts was already including those, and no other profile did so, there's no need to add experimental flags to these ones.

(issue #4801)
felipesanches added a commit that referenced this issue Aug 9, 2024
@felipesanches
Deprecation of Outline profile, and migration of its checks
a1fe4a4 
The Outline profile was also removed and its checks migrated to the Google Fonts profile.
As gfonts was already including those, and no other profile did so, there's no need to add experimental flags to these ones.

(issue #4801)
@felipesanches
Copy link
Collaborator Author

OK... UFO, Shaping and Outline profiles are gone, via #4812

Now what to do about the rest?

I think I'll treat NotoFonts as a special kind of vendor. And I'll probably deprecate Fontval profile and move the check to Universal, while making it optional (simply bail out if FontValidator is not found, or maybe add an opt-in flag?)

@felipesanches felipesanches modified the milestones: 0.12.10, 0.12.11 Aug 14, 2024
@felipesanches felipesanches mentioned this issue Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipesanches felipesanches

Labels
None yet
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
2 participants
@felipesanches @davelab6