Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Preview Feature is not working correctly in IOS #601

Open
neody3 opened this issue Jul 2, 2024 · 1 comment
Open

[BUG] Preview Feature is not working correctly in IOS #601

neody3 opened this issue Jul 2, 2024 · 1 comment
Labels
s: bug Something isn't working.

Comments

@neody3
Copy link

neody3 commented Jul 2, 2024

Describe the bug

Preview Feature is not working correctly in IOS
How to reproduce

Steps to reproduce the behavior:

  1. Go to Preview screen
  2. Unselect all images
  3. Confirm button still clickable when no images selected

Expected behavior

Confirm button is not clickable when no images selected

Screenshots (If contains)

Version information

  • Device: Iphone 15 virtual
  • OS: 17.0.0
  • Package Version: 9.1.0
  • Flutter Version: 3.22.0

Additional context

I found that compare two lists is not good here.
Should we use listEquals to compare two lists?
https://api.flutter.dev/flutter/foundation/listEquals.html

late final bool isSelectedPreviewing = selectedAssets == previewAssets;

@neody3 neody3 added the await investigate The issue is waiting for further investigation. label Jul 2, 2024
@AlexV525
Copy link
Member

I found that compare two lists is not good here. Should we use listEquals to compare two lists? https://api.flutter.dev/flutter/foundation/listEquals.html

late final bool isSelectedPreviewing = selectedAssets == previewAssets;

Not related.

@AlexV525 AlexV525 added s: bug Something isn't working. and removed await investigate The issue is waiting for further investigation. labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

2 participants