-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Property Editor] Add a tooltip for the property's default value and documentation #9058
Conversation
Note: I tried to have the info tooltip in input label (as initially described here: #8891 (comment)) but I couldn't get the gesture detector to recognize a hover and show the tooltip. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a test that verifies the contents of the new tooltip for a widget property?
Done! |
Whether or not the text should wrap. | ||
|
||
If null, the default value is platform dependent. On TargetPlatform.android, | ||
the default is true. On TargetPlatform.iOS, false. The remaining platforms | ||
also default to false. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you use String interpolation here instead? $softWrapDocumentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're also testing that the brackets are correctly removed, so it's not identical to the documentation string.
Default value: Alignment.bottomLeft | ||
|
||
Documentation: | ||
How to align the child. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment then lgtm
Fixes #8938
Each property input has an info icon to its left which, when hovered, displays a tooltip with the default value and documentation.