Skip to content

Commit e8b74a0

Browse files
committed
Added some clarifications
1 parent 5746cf5 commit e8b74a0

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

README.md

+6-5
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@ nested drive.
6767
directory to this local gocryptfs drive, and then syncs this gocryptfs drive
6868
to a remote server.
6969
- Doing this is relatively efficient compared to the first solution.
70-
(On my laptop, with about 20,000 files, it takes about 20 seconds to stat
71-
all files. Then syncing to to a remote server with SFTP takes about 40
72-
seconds to stat all files).
70+
(On my laptop with Intel Core i7-8565U, with about 20,000 files, it takes
71+
about 20 seconds to stat all files. Then syncing to to a remote server with
72+
SFTP takes about 40 seconds to stat all files).
7373
- Huge plus in this regard is no longer having to deal with FUSE on Windows.
7474
- Major disadvantage to this approach is one must have enough storage for
7575
both the entire gocryptfs drive and the plaintext files that we actually want.
@@ -99,8 +99,9 @@ introduces a simple LRU path lookup cache for frequently accessed paths.
9999

100100
With these simple cache mechanisms in place, Gocrypt SFTP outperforms as well
101101
as or even better than the second approach described in
102-
[Motivations](#motivations). On my laptop, with about 20,000 files, it takes
103-
under 1 minute to stat (in plaintext) all files in the remote gocryptfs drive.
102+
[Motivations](#motivations). On my laptop with Intel Core i7-8565U, with
103+
about 20,000 files, it takes under 1 minute to stat (in plaintext) all files
104+
in the remote gocryptfs drive.
104105

105106

106107

handlers/proxy.go

+2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ import (
99
"github.com/pkg/sftp"
1010
)
1111

12+
// Not used, just a reference implementation
13+
1214
func ProxyHandler(remoteClient *sftp.Client) sftp.Handlers {
1315
h := &proxy{client: remoteClient}
1416
return sftp.Handlers{

0 commit comments

Comments
 (0)