more unit tests for scroll-timeline-base functions

zouhir · zouhir · commit d58d074eb601 · 2020-04-06T15:20:11.000-07:00
diff --git a/.DS_Store b/.DS_Store
diff --git a/deploy.sh b/deploy.sh
@@ -4,7 +4,7 @@
 rm -rf build
 mkdir build
 
-# recursively copy demo/ dir to www/
+# recursively copy demo/ dir to build/
 cp -rf demo/ build/
 
 # copy demos root page that lists all demos
diff --git a/index.html b/index.html
@@ -5,7 +5,7 @@
     <meta name="viewport"
           content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0">
     <meta http-equiv="X-UA-Compatible" content="ie=edge">
-    <title>Local Dev Demos</title>
+    <title>ScrollTimeline Demos</title>
 </head>
 <body>
 <ul>
diff --git a/package.json b/package.json
@@ -9,7 +9,8 @@
     "watch": "microbundle watch -f iife",
     "dev": "run-all \"serve\" \" npm run watch \" ",
     "deploy": "npm run build && ./deploy.sh && gh-pages build",
-    "test:unit": "jest"
+    "test:unit": "jest",
+    "test:watch": "jest --watchAll"
   },
   "repository": {
     "type": "git",
diff --git a/src/scroll-timeline-base.js b/src/scroll-timeline-base.js
@@ -14,6 +14,8 @@
 
 import {parseLength} from './utils';
 
+const ORIENTATIONS = new Set()
+
 let scrollTimelineOptions = new WeakMap();
 
 function scrollEventSource(scrollSource) {
@@ -22,8 +24,8 @@ function scrollEventSource(scrollSource) {
   return scrollSource;
 }
 
-function calculateTargetEffectEnd(options) {
-  if (options.iterationCount == Infinity)
+export function calculateTargetEffectEnd(options) {
+  if (options.iterationCount === Infinity)
     return Infinity;
   return Math.max((options.startDelay || 0) + (options.duration || 0) * (options.iterationCount || 1) + (options.endDelay || 0), 0);
 }
@@ -34,62 +36,62 @@ export function installScrollOffsetExtension(parseFunction, evaluateFunction) {
   extensionScrollOffsetFunctions.push([parseFunction, evaluateFunction]);
 }
 
-function calculateMaxScrollOffset(scrollSource, orientation) {
+export function calculateMaxScrollOffset(scrollSource, orientation) {
   // TODO: Support other writing directions.
-  if (orientation == 'block')
+  if (orientation === 'block')
     orientation = 'vertical';
-  else if (orientation == 'inline')
+  else if (orientation === 'inline')
     orientation = 'horizontal';
-  if (orientation == 'vertical')
+  if (orientation === 'vertical')
     return scrollSource.scrollHeight - scrollSource.clientHeight;
-  else if (orientation == 'horizontal')
+  else if (orientation === 'horizontal')
     return scrollSource.scrollWidth - scrollSource.clientWidth;
 
 }
 
 function calculateScrollOffset(autoValue, scrollSource, orientation, offset, fn) {
   if (fn)
-    return fn(scrollSource, orientation, offset, autoValue == '0%' ? 'start' : 'end');
+    return fn(scrollSource, orientation, offset, autoValue === '0%' ? 'start' : 'end');
   // TODO: Support other writing directions.
-  if (orientation == 'block')
+  if (orientation === 'block')
     orientation = 'vertical';
-  else if (orientation == 'inline')
+  else if (orientation === 'inline')
     orientation = 'horizontal';
 
-  let maxValue = orientation == 'vertical' ?
+  let maxValue = orientation === 'vertical' ?
     scrollSource.scrollHeight - scrollSource.clientHeight :
     scrollSource.scrollWidth - scrollSource.clientWidth;
-  let parsed = parseLength(offset == 'auto' ? autoValue : offset);
-  if (parsed[2] == '%')
+  let parsed = parseLength(offset === 'auto' ? autoValue : offset);
+  if (parsed[2] === '%')
     return parseFloat(parsed[1]) * maxValue / 100;
   return parseFloat(parsed[1]);
 }
 
 function calculateTimeRange(scrollTimeline) {
   let timeRange = scrollTimeline.timeRange;
-  if (timeRange == 'auto') {
+  if (timeRange === 'auto') {
     timeRange = 0;
     let options = scrollTimelineOptions.get(scrollTimeline).animationOptions;
     for (let i = 0; i < options.length; i++) {
       timeRange = Math.max(timeRange, calculateTargetEffectEnd(options[i]));
     }
-    if (timeRange == Infinity)
+    if (timeRange === Infinity)
       timeRange = 0;
   }
   return timeRange;
 }
 
 function updateInternal() {
   let animations = scrollTimelineOptions.get(this).animations;
-  if (animations.length == 0)
+  if (animations.length === 0)
     return;
   let currentTime = this.currentTime;
   for (let i = 0; i < animations.length; i++) {
     // The web-animations spec says to throw a TypeError if you try to seek to
     // an unresolved time value from a resolved time value, so to polyfill the
     // expected behavior we cancel the underlying animation.
     if (currentTime == null) {
-      if (animations[i].playState == 'paused')
+      if (animations[i].playState === 'paused')
         animations[i].cancel();
     } else {
       animations[i].currentTime = currentTime;
@@ -108,7 +110,7 @@ function addAnimation(scrollTimeline, animation, options) {
 function removeAnimation(scrollTimeline, animation) {
   let animations = scrollTimelineOptions.get(scrollTimeline).animations;
   let index = animations.indexOf(animation);
-  if (index == -1)
+  if (index === -1)
     return;
   animations.splice(index, 1);
   scrollTimelineOptions.get(scrollTimeline).animationOptions.splice(index, 1);
diff --git a/tests/util.test.js b/tests/util.test.js
@@ -1,28 +1,28 @@
 import {parseLength} from '../src/utils';
 
 describe("parseLength util function", function () {
-  test("parseLength should return an array or=f length 3 for valid input", function () {
+  test("should return an array of length 3 for valid input", function () {
     let offset = '100px';
     expect(parseLength(offset).length).toEqual(3);
   });
 
-  test("parseLength should return an array or=f length 3 for valid input", function () {
+  test("can understand px as valid unit", function () {
     let num = '100';
     let unit = 'px';
     let offset = num + unit;
     expect(parseLength(offset)[1]).toEqual(num);
     expect(parseLength(offset)[2]).toEqual(unit);
   });
 
-  test("parseLength should return an array or=f length 3 for valid input", function () {
+  test("can understand % as valid input", function () {
     let num = '99999';
     let unit = '%';
     let offset = num + unit;
     expect(parseLength(offset)[1]).toEqual(num);
     expect(parseLength(offset)[2]).toEqual(unit);
   });
 
-  test("parseLength should return null for invalid input", function () {
+  test("should null for invalid input", function () {
     let num = '100';
     let unit = '&';
     let offset = num + unit;
