Skip to content

Wrong image sources #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Yarnacle opened this issue Nov 19, 2022 · 4 comments
Closed

Wrong image sources #284

Yarnacle opened this issue Nov 19, 2022 · 4 comments

Comments

@Yarnacle
Copy link

🐞 Problem

Some of the objects listed in src/components/ProjectList/listOfProjects.js have an incorrect image source.
For example, the CircuitVerse card on the website looks like this:
CircuitVerse card

So far, I have noticed the following project cards with the same issue:

  • aprenda-go-com-testes

🎯 Goal

Properly display projects cards

💡 Possible solutions

It seems the problem is caused by linking a GitHub page rather than an image.
For example, the CircuitVerse object in listOfProjects.js has its imageSrc property set to https://github.com/CircuitVerse/CircuitVerse/blob/master/app/assets/images/CircuitVerse.png, which is a link to this:
Github page of CircuitVerse logo

A solution to this problem would be to replace the incorrect image sources with each image's raw.githubusercontent.com URL.

📋 Steps to solve the problem

  • Comment below about what you've started working on.
  • Add, commit, push your changes.
  • Submit a pull request and add this in comments - Addresses #<put issue number here>
  • Ask for a review in comments section of pull request.
  • Celebrate your contribution to this project. 🎉
@HrutikaBadgeri
Copy link

please assign me this issue

@arunraj3
Copy link

arunraj3 commented Apr 9, 2023

I'm New to Open source can i contribute to this issue ?

@nickjfrench
Copy link

All broken image sources (21 in total) have been updated in my pull request #396.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants
@Roshanjossey @nickjfrench @HrutikaBadgeri @arunraj3 @Yarnacle and others