Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update stack too #79

Merged
merged 1 commit into from
Feb 14, 2025
Merged

fix: update stack too #79

merged 1 commit into from
Feb 14, 2025

Conversation

wrenix
Copy link
Contributor

@wrenix wrenix commented Feb 12, 2025

No description provided.

@wrenix wrenix requested a review from JC5 as a code owner February 12, 2025 14:36
@wrenix wrenix force-pushed the update branch 2 times, most recently from 834f717 to 29e1454 Compare February 12, 2025 14:45
@JC5
Copy link
Member

JC5 commented Feb 12, 2025

Hey,

Are you sure the indentation is correct?

@wrenix
Copy link
Contributor Author

wrenix commented Feb 13, 2025

Of course, without indent is totally confusing:
i prefer:

dependencies:
  - name: firefly-db
  - name: firefly-iii

over:

dependencies:
- name: firefly-db
- name: firefly-iii

see file here:
https://github.com/firefly-iii/kubernetes/blob/d364ab661c07ecb75cf3c3e346200949b1e40ead/charts/firefly-iii-stack/Chart.yaml

@JC5 JC5 merged commit 9ffcd6d into firefly-iii:main Feb 14, 2025
3 checks passed
@wrenix wrenix deleted the update branch February 14, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JC5 JC5 JC5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wrenix @JC5