Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] picoschema does not implement all the features of JS #610

Open
jba opened this issue Jul 12, 2024 · 3 comments · May be fixed by #1221
Open

[Go] picoschema does not implement all the features of JS #610

jba opened this issue Jul 12, 2024 · 3 comments · May be fixed by #1221
Assignees
@alonsopec89
Labels
bug Something isn't working go
Milestone
go-0.2.0

Comments

@jba
Copy link
Contributor

jba commented Jul 12, 2024

The Go implementation of picoschema is not aligned with the JS one.
See #528.
@jba jba added bug Something isn't working go labels Jul 12, 2024
@jba
Copy link
Contributor Author

jba commented Jul 17, 2024

Replacing github.com/invopop/jsonschema should be a blocker for moving to v1.0.

@chrisraygill chrisraygill removed the P1 label Jul 18, 2024
@chrisraygill chrisraygill modified the milestones: js-0.6.0, go-0.2.0 Jul 19, 2024
@apascal07
Copy link
Collaborator

@jba Can you add some color to why you think we should replace github.com/invopop/jsonschema?

@apascal07 apascal07 self-assigned this Jul 24, 2024
@jba
Copy link
Contributor Author

jba commented Jul 24, 2024

invopop doesn't support multiple types, and probably never will (invopop/jsonschema#134).
That's the main one.

@apascal07 apascal07 assigned alonsopec89 and unassigned pavelgj and apascal07 Nov 7, 2024
@alonsopec89 alonsopec89 linked a pull request Nov 11, 2024 that will close this issue
[GO] allow multiple types in jsonschema #1221
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alonsopec89 alonsopec89

Labels
bug Something isn't working go
Projects
Genkit Backlog
Status: In Progress
Milestone
go-0.2.0
Development

Successfully merging a pull request may close this issue.

[GO] allow multiple types in jsonschema firebase/genkit
5 participants
@pavelgj @apascal07 @chrisraygill @jba @alonsopec89