Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App hosting should support pnpm workspace projects #7478

Open
debkanchan opened this issue Jul 22, 2024 · 3 comments
Open

App hosting should support pnpm workspace projects #7478

debkanchan opened this issue Jul 22, 2024 · 3 comments
Assignees
Labels
api: apphosting Issues related to App Hosting type: feature request

Comments

@debkanchan
Copy link

[REQUIRED] Environment info

firebase-tools: 13.13.0

Platform: MacOS

[REQUIRED] Test case

Steps to reproduce should be enough

[REQUIRED] Steps to reproduce

  1. Create a new pnpm workspace with the following pnpm-workspace.yaml
packages:
  - "apps/*"
  - "packages/*"
  1. inside /apps/main init a new nextjs app
  2. inside /packages/random init empty js project
  3. in project root run pnpm i
  4. commit and push to Github
  5. create new app hosting backend, specify app directory to /apps/main

[REQUIRED] Expected behaviour

Deploys the app

[REQUIRED] Actual behaviour

failed to build, lockfile not found

@google-oss-bot
Copy link
Contributor

This issue does not seem to follow the issue template. Make sure you provide all the required information.

@jbalidiong jbalidiong added the api: apphosting Issues related to App Hosting label Jul 22, 2024
@aalej
Copy link
Contributor

aalej commented Jul 23, 2024

Hey @debkanchan, thanks for reaching out and for providing a detailed report. I discussed this with our engineering team. Currently, pnpm is supported, however pnpm workspaces is not. For now, I’ll mark this as a feature request.

@benyap
Copy link

benyap commented Aug 15, 2024

Hi @aalej, just thought I'd chip in and mention a similar discussion that was started here: #7206 (reply in thread)

Looking forward to see official support for pnpm workspaces at some point in the future.

@joehan joehan changed the title App hosting fails to build pnpm workspace projects App hosting should support pnpm workspace projects Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: apphosting Issues related to App Hosting type: feature request
Projects
None yet
Development

No branches or pull requests

5 participants