Merge branch 'master' into service_account_param

Author: taeold

.eslintignore

@@ -4,3 +4,4 @@ lib
 node_modules
 standalone
 templates
+.firebase

.eslintrc.js

@@ -122,7 +122,11 @@ module.exports = {
   // TODO(jamesdaniels): add this to overrides instead
   ignorePatterns: [
     "src/dynamicImport.js",
-    "scripts/webframeworks-deploy-tests/hosting/**",
+    "scripts/webframeworks-deploy-tests/nextjs/**",
+    "scripts/webframeworks-deploy-tests/angular/**",
     "scripts/frameworks-tests/vite-project/**",
+    "/src/frameworks/docs/**",
+    // This file is taking a very long time to lint, 2-4m
+    "src/emulator/auth/schema.ts",
   ],
 };

.github/workflows/node-test.yml

@@ -24,7 +24,7 @@ jobs:
     strategy:
       matrix:
         node-version:
-          - "16"
+          - "18"
     steps:
       - uses: actions/checkout@v3
         with:
@@ -35,7 +35,7 @@ jobs:
           cache: npm
           cache-dependency-path: npm-shrinkwrap.json
 
-      - run: npm i -g npm@8.7
+      - run: npm i -g npm@9.5
       - run: npm ci
       - run: npm run lint:changed-files
 
@@ -44,7 +44,6 @@ jobs:
     strategy:
       matrix:
         node-version:
-          - "14"
           - "16"
           - "18"
     steps:
@@ -55,12 +54,12 @@ jobs:
           cache: npm
           cache-dependency-path: npm-shrinkwrap.json
 
-      - run: npm i -g npm@8.7
+      - run: npm i -g npm@9.5
       - run: npm ci
       - run: npm test -- -- --forbid-only
 
       - uses: codecov/codecov-action@v3
-        if: matrix.node-version == '14'
+        if: matrix.node-version == '16'
 
   integration:
     needs: unit
@@ -80,7 +79,7 @@ jobs:
       fail-fast: false
       matrix:
         node-version:
-          - "16"
+          - "18"
         script:
           - npm run test:client-integration
           - npm run test:emulator
@@ -94,6 +93,7 @@ jobs:
           - npm run test:storage-emulator-integration
           - npm run test:triggers-end-to-end
           - npm run test:triggers-end-to-end:inspect
+          - npm run test:webframeworks-deploy
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
@@ -109,7 +109,7 @@ jobs:
           key: ${{ runner.os }}-firebase-emulators-${{ hashFiles('emulator-cache/**') }}
         continue-on-error: true
 
-      - run: npm i -g npm@8.7
+      - run: npm i -g npm@9.5
       - run: npm ci
       - run: echo ${{ secrets.service_account_json_base64 }} | base64 -d > ./scripts/service-account.json
       - run: ${{ matrix.script }}
@@ -136,13 +136,13 @@ jobs:
       fail-fast: false
       matrix:
         node-version:
-          - "16"
+          - "18"
         script:
           - npm run test:hosting
           # - npm run test:hosting-rewrites # Long-running test that might conflict across test runs. Run this manually.
           - npm run test:client-integration
           - npm run test:emulator
-          # - npm run test:import-export # Fails becuase port 4000 is taken after first run - hub not shhutting down?
+          # - npm run test:import-export # Fails becuase port 4000 is taken after first run - hub not shutting down?
           # - npm run test:extensions-emulator # Fails due to cannot find module sharp (not waiting for npm install?)
           - npm run test:functions-discover
           - npm run test:triggers-end-to-end
@@ -172,7 +172,7 @@ jobs:
 
       - run: echo ${{ secrets.service_account_json_base64 }} > tmp.txt
       - run: certutil -decode tmp.txt scripts/service-account.json
-      - run: npm i -g npm@8.7
+      - run: npm i -g npm@9.5
       - run: npm ci
       - run: ${{ matrix.script }}
       - name: Print debug logs
@@ -185,7 +185,7 @@ jobs:
     strategy:
       matrix:
         node-version:
-          - "16"
+          - "18"
 
     steps:
       - uses: actions/checkout@v3
@@ -195,7 +195,7 @@ jobs:
           node-version: ${{ matrix.node-version }}
           cache: npm
           cache-dependency-path: npm-shrinkwrap.json
-      - run: npm i -g npm@8.7
+      - run: npm i -g npm@9.5
       # --ignore-scripts prevents the `prepare` script from being run.
       - run: npm install --package-lock-only --ignore-scripts
       - run: "git diff --exit-code -- npm-shrinkwrap.json || (echo 'Error: npm-shrinkwrap.json is changed during npm install! Please make sure to use npm >= 8 and commit npm-shrinkwrap.json.' && false)"
@@ -206,7 +206,7 @@ jobs:
     strategy:
       matrix:
         node-version:
-          - "16"
+          - "18"
 
     steps:
       - uses: actions/checkout@v3

.gitignore

@@ -22,3 +22,4 @@ scripts/*.json
 
 lib/
 dev/
+clean/

.prettierignore

@@ -3,3 +3,6 @@
 /lib/**/*
 /CONTRIBUTING.md
 /scripts/frameworks-tests/vite-project/**
+/scripts/webframeworks-deploy-tests/angular/**
+/scripts/webframeworks-deploy-tests/nextjs/**
+/src/frameworks/docs/**

CHANGELOG.md

@@ -1,2 +1,3 @@
-- Releases Cloud Firestore emulator v1.16.1, which adds support for read_time in ListCollectionIds.
+- Fixes an issue in the EventArc emualtor where events missing optional fields would cause crashes. (#5803)
+- Fixes an issue running `firebase emulators:start` and `firebase deploy` when Python Cloud Functions directory path has spaces. (#5830)
 - Supports parametrized configuration of ServiceAccount in Functions and Function triggers.