Skip to content

Commit deb3fd0

Browse files
dconeybedconeybe
authored
Firestore: Remove obsolete NOLINT comments (#14347)
1 parent ca51b03 commit deb3fd0

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+75
-77
lines changed

Diff for: ‎Firestore/core/include/firebase/firestore/timestamp.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323
#include <string>
2424

2525
#if !defined(_STLPORT_VERSION)
26-
#include <chrono> // NOLINT(build/c++11)
27-
#endif // !defined(_STLPORT_VERSION)
26+
#include <chrono>
27+
#endif // !defined(_STLPORT_VERSION)
2828

2929
namespace firebase {
3030

Diff for: ‎Firestore/core/src/api/document_reference.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
#include "Firestore/core/src/api/document_reference.h"
1818

19-
#include <future> // NOLINT(build/c++11)
19+
#include <future>
2020
#include <memory>
2121

2222
#include "Firestore/core/src/api/collection_reference.h"

Diff for: ‎Firestore/core/src/api/firestore.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
#define FIRESTORE_CORE_SRC_API_FIRESTORE_H_
1919

2020
#include <memory>
21-
#include <mutex> // NOLINT(build/c++11)
21+
#include <mutex>
2222
#include <string>
2323

2424
#include "Firestore/core/src/api/api_fwd.h"

Diff for: ‎Firestore/core/src/api/load_bundle_task.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
#include "Firestore/core/src/api/load_bundle_task.h"
1818

19-
#include <mutex> // NOLINT(build/c++11)
19+
#include <mutex>
2020
#include <utility>
2121

2222
#include "Firestore/core/src/util/autoid.h"

Diff for: ‎Firestore/core/src/api/load_bundle_task.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
#include <cstdint>
2020
#include <functional>
2121
#include <memory>
22-
#include <mutex> // NOLINT(build/c++11)
22+
#include <mutex>
2323
#include <string>
2424
#include <utility>
2525
#include <vector>

Diff for: ‎Firestore/core/src/api/query_core.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
#include "Firestore/core/src/api/query_core.h"
1818

19-
#include <future> // NOLINT(build/c++11)
19+
#include <future>
2020
#include <memory>
2121
#include <utility>
2222
#include <vector>

Diff for: ‎Firestore/core/src/core/event_listener.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
#define FIRESTORE_CORE_SRC_CORE_EVENT_LISTENER_H_
1919

2020
#include <memory>
21-
#include <mutex> // NOLINT(build/c++11)
21+
#include <mutex>
2222
#include <utility>
2323

2424
#include "Firestore/core/src/util/executor.h"

Diff for: ‎Firestore/core/src/core/firestore_client.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
#include "Firestore/core/src/core/firestore_client.h"
1818

1919
#include <functional>
20-
#include <future> // NOLINT(build/c++11)
20+
#include <future>
2121
#include <memory>
2222
#include <string>
2323
#include <utility>

Diff for: ‎Firestore/core/src/credentials/firebase_app_check_credentials_provider_apple.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
#import <Foundation/Foundation.h>
2525

2626
#include <memory>
27-
#include <mutex> // NOLINT(build/c++11)
27+
#include <mutex>
2828
#include <string>
2929
#include <utility>
3030

Diff for: ‎Firestore/core/src/credentials/firebase_auth_credentials_provider_apple.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
#import <Foundation/Foundation.h>
2525

2626
#include <memory>
27-
#include <mutex> // NOLINT(build/c++11)
27+
#include <mutex>
2828
#include <utility>
2929

3030
#include "Firestore/core/src/credentials/credentials_provider.h"

Diff for: ‎Firestore/core/src/local/leveldb_remote_document_cache.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
#include "Firestore/core/src/local/leveldb_remote_document_cache.h"
1818

1919
#include <string>
20-
#include <thread> // NOLINT(build/c++11)
20+
#include <thread>
2121
#include <utility>
2222

2323
#include "Firestore/Protos/nanopb/firestore/local/maybe_document.nanopb.h"

Diff for: ‎Firestore/core/src/local/leveldb_remote_document_cache.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
#include <memory>
2121
#include <string>
22-
#include <thread> // NOLINT(build/c++11)
22+
#include <thread>
2323
#include <vector>
2424

2525
#include "Firestore/core/src/core/query.h"

Diff for: ‎Firestore/core/src/local/lru_garbage_collector.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
#include "Firestore/core/src/local/lru_garbage_collector.h"
1818

19-
#include <chrono> // NOLINT(build/c++11)
19+
#include <chrono>
2020
#include <queue>
2121
#include <string>
2222
#include <utility>

Diff for: ‎Firestore/core/src/remote/exponential_backoff.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
#ifndef FIRESTORE_CORE_SRC_REMOTE_EXPONENTIAL_BACKOFF_H_
1818
#define FIRESTORE_CORE_SRC_REMOTE_EXPONENTIAL_BACKOFF_H_
1919

20-
#include <chrono> // NOLINT(build/c++11)
20+
#include <chrono>
2121
#include <memory>
2222

2323
#include "Firestore/core/src/util/async_queue.h"

Diff for: ‎Firestore/core/src/remote/grpc_completion.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@
1717
#ifndef FIRESTORE_CORE_SRC_REMOTE_GRPC_COMPLETION_H_
1818
#define FIRESTORE_CORE_SRC_REMOTE_GRPC_COMPLETION_H_
1919

20-
#include <chrono> // NOLINT(build/c++11)
20+
#include <chrono>
2121
#include <functional>
22-
#include <future> // NOLINT(build/c++11)
22+
#include <future>
2323
#include <memory>
2424
#include <utility>
2525

Diff for: ‎Firestore/core/src/remote/grpc_connection.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
#include <cstdlib>
2020

2121
#include <algorithm>
22-
#include <mutex> // NOLINT(build/c++11)
22+
#include <mutex>
2323
#include <string>
2424
#include <utility>
2525

Diff for: ‎Firestore/core/src/remote/grpc_stream.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616

1717
#include "Firestore/core/src/remote/grpc_stream.h"
1818

19-
#include <chrono> // NOLINT(build/c++11)
20-
#include <future> // NOLINT(build/c++11)
19+
#include <chrono>
20+
#include <future>
2121

2222
#include "Firestore/core/src/remote/grpc_connection.h"
2323
#include "Firestore/core/src/remote/grpc_util.h"

Diff for: ‎Firestore/core/src/remote/online_state_tracker.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
#include "Firestore/core/src/remote/online_state_tracker.h"
1818

19-
#include <chrono> // NOLINT(build/c++11)
19+
#include <chrono>
2020

2121
#include "Firestore/core/src/util/executor.h"
2222
#include "Firestore/core/src/util/hard_assert.h"

Diff for: ‎Firestore/core/src/remote/stream.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
#include "Firestore/core/src/remote/stream.h"
1818

19-
#include <chrono> // NOLINT(build/c++11)
19+
#include <chrono>
2020
#include <utility>
2121

2222
#include "Firestore/core/include/firebase/firestore/firestore_errors.h"

Diff for: ‎Firestore/core/src/util/async_queue.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@
1818
#define FIRESTORE_CORE_SRC_UTIL_ASYNC_QUEUE_H_
1919

2020
#include <atomic>
21-
#include <chrono> // NOLINT(build/c++11)
21+
#include <chrono>
2222
#include <functional>
2323
#include <memory>
24-
#include <mutex> // NOLINT(build/c++11)
24+
#include <mutex>
2525
#include <vector>
2626

2727
#include "Firestore/core/src/util/executor.h"

Diff for: ‎Firestore/core/src/util/background_queue.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@
1717
#ifndef FIRESTORE_CORE_SRC_UTIL_BACKGROUND_QUEUE_H_
1818
#define FIRESTORE_CORE_SRC_UTIL_BACKGROUND_QUEUE_H_
1919

20-
#include <condition_variable> // NOLINT(build/c++11)
20+
#include <condition_variable>
2121
#include <functional>
22-
#include <mutex> // NOLINT(build/c++11)
22+
#include <mutex>
2323

2424
namespace firebase {
2525
namespace firestore {

Diff for: ‎Firestore/core/src/util/executor.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
#ifndef FIRESTORE_CORE_SRC_UTIL_EXECUTOR_H_
1818
#define FIRESTORE_CORE_SRC_UTIL_EXECUTOR_H_
1919

20-
#include <chrono> // NOLINT(build/c++11)
20+
#include <chrono>
2121
#include <functional>
2222
#include <memory>
2323
#include <string>

Diff for: ‎Firestore/core/src/util/executor_libdispatch.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@
1919

2020
#include <dispatch/dispatch.h>
2121

22-
#include <chrono> // NOLINT(build/c++11)
23-
#include <condition_variable> // NOLINT(build/c++11)
22+
#include <chrono>
23+
#include <condition_variable>
2424
#include <functional>
2525
#include <memory>
26-
#include <mutex> // NOLINT(build/c++11)
26+
#include <mutex>
2727
#include <string>
2828
#include <unordered_map>
2929
#include <unordered_set>

Diff for: ‎Firestore/core/src/util/executor_std.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
#include "Firestore/core/src/util/executor_std.h"
1818

19-
#include <future> // NOLINT(build/c++11)
19+
#include <future>
2020
#include <memory>
2121
#include <sstream>
2222

Diff for: ‎Firestore/core/src/util/executor_std.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@
1919

2020
#include <algorithm>
2121
#include <atomic>
22-
#include <condition_variable> // NOLINT(build/c++11)
22+
#include <condition_variable>
2323
#include <deque>
2424
#include <memory>
25-
#include <mutex> // NOLINT(build/c++11)
25+
#include <mutex>
2626
#include <string>
27-
#include <thread> // NOLINT(build/c++11)
27+
#include <thread>
2828
#include <utility>
2929
#include <vector>
3030

Diff for: ‎Firestore/core/src/util/schedule.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@
1818
#define FIRESTORE_CORE_SRC_UTIL_SCHEDULE_H_
1919

2020
#include <algorithm>
21-
#include <condition_variable> // NOLINT(build/c++11)
21+
#include <condition_variable>
2222
#include <deque>
23-
#include <mutex> // NOLINT(build/c++11)
23+
#include <mutex>
2424
#include <vector>
2525

2626
#include "Firestore/core/src/util/executor.h"

Diff for: ‎Firestore/core/src/util/task.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
#include "Firestore/core/src/util/task.h"
1818

19-
#include <chrono> // NOLINT(build/c++11)
19+
#include <chrono>
2020
#include <cstdint>
2121
#include <utility>
2222

Diff for: ‎Firestore/core/src/util/task.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@
1818
#define FIRESTORE_CORE_SRC_UTIL_TASK_H_
1919

2020
#include <atomic>
21-
#include <condition_variable> // NOLINT(build/c++11)
21+
#include <condition_variable>
2222
#include <memory>
23-
#include <mutex> // NOLINT(build/c++11)
24-
#include <thread> // NOLINT(build/c++11)
23+
#include <mutex>
24+
#include <thread>
2525

2626
#include "Firestore/core/src/util/executor.h"
2727

Diff for: ‎Firestore/core/src/util/testing_hooks.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
#include "Firestore/core/src/util/testing_hooks.h"
1818

1919
#include <functional>
20-
#include <mutex> // NOLINT(build/c++11)
20+
#include <mutex>
2121
#include <type_traits>
2222
#include <unordered_map>
2323
#include <utility>

Diff for: ‎Firestore/core/src/util/testing_hooks.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
#include <functional>
2121
#include <memory>
22-
#include <mutex> // NOLINT(build/c++11)
22+
#include <mutex>
2323
#include <string>
2424
#include <unordered_map>
2525

Diff for: ‎Firestore/core/src/util/thread_safe_memoizer.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
#define FIRESTORE_CORE_SRC_UTIL_THREAD_SAFE_MEMOIZER_H_
1919

2020
#include <functional>
21-
#include <mutex> // NOLINT(build/c++11)
21+
#include <mutex>
2222
#include <vector>
2323

2424
namespace firebase {

Diff for: ‎Firestore/core/test/unit/api/load_bundle_task_test.cc

+3-3
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@
1414
* limitations under the License.
1515
*/
1616

17-
#include <chrono> // NOLINT(build/c++11)
18-
#include <mutex> // NOLINT(build/c++11)
17+
#include <chrono>
18+
#include <mutex>
1919
#include <queue>
20-
#include <thread> // NOLINT(build/c++11)
20+
#include <thread>
2121

2222
#include "Firestore/core/include/firebase/firestore/firestore_errors.h"
2323
#include "Firestore/core/src/api/load_bundle_task.h"

Diff for: ‎Firestore/core/test/unit/core/query_listener_test.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
#include "Firestore/core/src/core/query_listener.h"
1818

19-
#include <future> // NOLINT(build/c++11)
19+
#include <future>
2020
#include <memory>
2121
#include <utility>
2222
#include <vector>

Diff for: ‎Firestore/core/test/unit/credentials/firebase_app_check_credentials_provider_test.mm

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818

1919
#import <FirebaseAppCheckInterop/FirebaseAppCheckInterop.h>
2020

21-
#include <chrono> // NOLINT(build/c++11)
22-
#include <future> // NOLINT(build/c++11)
21+
#include <chrono>
22+
#include <future>
2323

2424
#import "FirebaseCore/Extension/FIRAppInternal.h"
2525

Diff for: ‎Firestore/core/test/unit/credentials/firebase_auth_credentials_provider_test.mm

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616

1717
#include "Firestore/core/src/credentials/firebase_auth_credentials_provider_apple.h"
1818

19-
#include <chrono> // NOLINT(build/c++11)
20-
#include <future> // NOLINT(build/c++11)
19+
#include <chrono>
20+
#include <future>
2121
#include <memory>
2222

2323
#import "FirebaseAuth/Interop/Public/FirebaseAuthInterop/FIRAuthInterop.h"

Diff for: ‎Firestore/core/test/unit/local/local_store_test.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
#include "Firestore/core/test/unit/local/local_store_test.h"
1818

19-
#include <thread> // NOLINT(build/c++11)
19+
#include <thread>
2020
#include <unordered_map>
2121
#include <utility>
2222
#include <vector>

Diff for: ‎Firestore/core/test/unit/remote/exponential_backoff_test.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
#include "Firestore/core/src/remote/exponential_backoff.h"
1818

19-
#include <chrono> // NOLINT(build/c++11)
19+
#include <chrono>
2020

2121
#include "Firestore/core/src/util/async_queue.h"
2222
#include "Firestore/core/src/util/executor.h"

Diff for: ‎Firestore/core/test/unit/remote/grpc_stream_tester.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
#define FIRESTORE_CORE_TEST_UNIT_REMOTE_GRPC_STREAM_TESTER_H_
1919

2020
#include <functional>
21-
#include <future> // NOLINT(build/c++11)
21+
#include <future>
2222
#include <initializer_list>
2323
#include <memory>
2424
#include <string>

0 commit comments

Comments
 (0)