Skip to content

Commit 2b30c54

Browse files
authored
fix a typo in integration test (#2131)
* fix a typo in integration test * relax else condition to catch all abnormal cases
1 parent 93ad9fc commit 2b30c54

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

Diff for: Firestore/Example/Tests/Integration/API/FIRDatabaseTests.mm

+10-10
Original file line numberDiff line numberDiff line change
@@ -594,7 +594,7 @@ - (void)testDocumentSnapshotEvents_nonExistent {
594594
XCTAssertFalse(doc.exists);
595595
[snapshotCompletion fulfill];
596596

597-
} else if (callbacks == 2) {
597+
} else {
598598
XCTFail("Should not have received this callback");
599599
}
600600
}];
@@ -625,7 +625,7 @@ - (void)testDocumentSnapshotEvents_forAdd {
625625
XCTAssertEqual(doc.metadata.hasPendingWrites, YES);
626626
[dataCompletion fulfill];
627627

628-
} else if (callbacks == 3) {
628+
} else {
629629
XCTFail("Should not have received this callback");
630630
}
631631
}];
@@ -666,7 +666,7 @@ - (void)testDocumentSnapshotEvents_forAddIncludingMetadata {
666666
XCTAssertEqual(doc.metadata.hasPendingWrites, NO);
667667
[dataCompletion fulfill];
668668

669-
} else if (callbacks == 4) {
669+
} else {
670670
XCTFail("Should not have received this callback");
671671
}
672672
}];
@@ -706,7 +706,7 @@ - (void)testDocumentSnapshotEvents_forChange {
706706
XCTAssertEqual(doc.metadata.hasPendingWrites, YES);
707707
[changeCompletion fulfill];
708708

709-
} else if (callbacks == 3) {
709+
} else {
710710
XCTFail("Should not have received this callback");
711711
}
712712
}];
@@ -760,7 +760,7 @@ - (void)testDocumentSnapshotEvents_forChangeIncludingMetadata {
760760
XCTAssertEqual(doc.metadata.isFromCache, NO);
761761
[changeCompletion fulfill];
762762

763-
} else if (callbacks == 5) {
763+
} else {
764764
XCTFail("Should not have received this callback");
765765
}
766766
}];
@@ -799,7 +799,7 @@ - (void)testDocumentSnapshotEvents_forDelete {
799799
XCTAssertFalse(doc.exists);
800800
[changeCompletion fulfill];
801801

802-
} else if (callbacks == 3) {
802+
} else {
803803
XCTFail("Should not have received this callback");
804804
}
805805
}];
@@ -847,7 +847,7 @@ - (void)testDocumentSnapshotEvents_forDeleteIncludingMetadata {
847847
XCTAssertEqual(doc.metadata.isFromCache, NO);
848848
[changeCompletion fulfill];
849849

850-
} else if (callbacks == 4) {
850+
} else {
851851
XCTFail("Should not have received this callback");
852852
}
853853
}];
@@ -886,7 +886,7 @@ - (void)testQuerySnapshotEvents_forAdd {
886886
XCTAssertEqual(docSet.documents[0].metadata.hasPendingWrites, YES);
887887
[changeCompletion fulfill];
888888

889-
} else if (callbacks == 3) {
889+
} else {
890890
XCTFail("Should not have received a third callback");
891891
}
892892
}];
@@ -929,7 +929,7 @@ - (void)testQuerySnapshotEvents_forChange {
929929
XCTAssertEqual(docSet.documents[0].metadata.hasPendingWrites, YES);
930930
[changeCompletion fulfill];
931931

932-
} else if (callbacks == 3) {
932+
} else {
933933
XCTFail("Should not have received a third callback");
934934
}
935935
}];
@@ -969,7 +969,7 @@ - (void)testQuerySnapshotEvents_forDelete {
969969
XCTAssertEqual(docSet.count, 0);
970970
[changeCompletion fulfill];
971971

972-
} else if (callbacks == 4) {
972+
} else {
973973
XCTFail("Should not have received a third callback");
974974
}
975975
}];

0 commit comments

Comments
 (0)