Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertex AI: Should ImagenInlineImage#data be renamed ImagenInlineImage#bytesBase64Encoded ? #6786

Open
thatfiredev opened this issue Mar 20, 2025 · 0 comments
Labels

Comments

@thatfiredev
Copy link
Member

The ImagenInlineImage#data is currently documented as:

In reality, ImagenInlineImage#data contains the Base64 encoded image.

The Flutter and JS SDKs call it bytesBase64Encoded and their ref docs correctly mention the returned data is base64 encoded.
Renaming this field (data -> bytesBase64Encoded) would be a breaking change. But since Imagen support is in public preview, I think we should consider making the change when it goes GA.

For now, I think we should update the ref docs to point out the returned bytes are base64 encoded. I opened #6785 for that.


It looks like the Swift SDK doesn't expose the base64 encoded image, it decodes it and returns as data: Data. I opened firebase/firebase-ios-sdk#14603 to discuss whether it should expose the base64 images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant