Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Norwegian language code (no) #14214

Open
Tor2r opened this issue Sep 11, 2024 · 2 comments
Open

Wrong Norwegian language code (no) #14214

Tor2r opened this issue Sep 11, 2024 · 2 comments
Labels

Comments

@Tor2r
Copy link
Contributor

Tor2r commented Sep 11, 2024

Package

filament/filament

Package Version

v3.2.111

Laravel Version

v11.22.0

Livewire Version

v3.5.6

PHP Version

PHP 8.3

Problem description

Norway have two written languages, Norsk Bokmål (nb) and Nynorsk (nn).
Laravel lang have both of these which translates your Laravel application.

Since Filament uses "no" you wount benefint from these translation, like the validation messages.

When you set your language to "no" Filament is translated as expected, but the rest of your Laravel application is not, and vice versa.

Expected behavior

Setting language to "nb" would translate both Laravel application and Filament.

Steps to reproduce

Install Laravel, Livewire, Filament and Laravel lang.
Sett locale to "no" or "nb"
Add a user.
Log in.
Go to "Edit user"
Fill in a short password.
Validation message would be in another language than the Filament app.

Reproduction repository (issue will be closed if this is not valid)

https://github.com/Tor2r/novsnb

Relevant log output

No response

Donate 💰 to fund this issue

  • You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
  • 100% of the funding will be distributed between the Filament core team to run all aspects of the project.
  • Thank you in advance for helping us make maintenance sustainable!
Fund with Polar
@Tor2r Tor2r added bug Something isn't working medium priority unconfirmed labels Sep 11, 2024
@Tor2r
Copy link
Contributor Author

Tor2r commented Sep 11, 2024

I will gladly pull request a "nb" language to Filament, but I just don't know if that is the correct way to go, since there already is a "no" version.

@ekandreas
Copy link

Hopefully this will be fixed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

2 participants