Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with rotation/radius in extractRadialOrDiamondGradientParams #97

Open
ianobermiller opened this issue Apr 27, 2022 · 0 comments
Open

Comments

@ianobermiller
Copy link

I think there is something off about how rotation and radius are computed based on the transform. I've created a test file with two equivalent radial gradients. The results look like this (numbers rounded for clarity):

// both have size 300x600

// A
transform = [[ 0, -0.5, 1], [ 0.5, 0, 0.5]]
radius = [300, 600]
rotation = 90

// B
transform = [[0.5, 0, 0.5], [0, -0.5, 1]]
radius = [300, 600]
rotation = 0

Notice that A has a rotation of 90, whereas B as a rotation of 0. Since all other params are the same and they render the same, if I were to convert the radius and rotation to SVG params then A would render incorrectly.

It also may be the case that radius and rotation cannot be used in conjunction, then I will need a different solution, perhaps using the matrix directly in an SVG.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant