Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectEdit needs to be split up #5

Open
stubb opened this issue Mar 14, 2016 · 4 comments
Open

ObjectEdit needs to be split up #5

stubb opened this issue Mar 14, 2016 · 4 comments

Comments

@stubb
Copy link
Member

stubb commented Mar 14, 2016

From @prock-fife on April 6, 2012 14:51

This issue was reported by chewie

The ObjectEdit plugin is too bloated ATM. It should be split up into several minor plugins like:

  • highlight selected instance(s)
  • animation viewer
  • instance editor (e.g. instance id; NOTE: most of instance properties have to be stored / organised by the clients game data structure, so we only provide a mini plugin here)
  • object editor (e.g. blocking properties)

Copied from original issue: fifengine/fifengine#685

@stubb
Copy link
Member Author

stubb commented Mar 14, 2016

From @prock-fife on April 6, 2012 16:29

This comment was posted by chewie

(In [3907]) - added InstanceHighlighter plugin
- selected instances will now get a color overlay (can be switched to outline in the plugin code)
- removed instance highlighting from ObjectEdit plugin

  • added docking status saving to ToolBar widget class, added default docking settings for Toolbox
    • set name attribute for ToolBox to 'ToolBox' (was an empty string)
  • re-arranged init order in MainWindow.initGui() to make dockareas available for ToolBar
  • small change to screenshot icon to give it a bit more space on the left

related to refs #685

@stubb
Copy link
Member Author

stubb commented Mar 14, 2016

From @prock-fife on April 10, 2012 21:12

This comment was posted by chewie

(In [3910]) - re-enabled saving for ObjectEdit plugin

  • implemented XMLObjectSaver which allows serialization of a fife.Object
    • NOTE: only well-formed xml files are accepted
    • NOTE: provides a compat-mode to scan for tree roots, but also uses new tree root
    • added namespace sorting to ObjectSelector
    • related to refs #685

@stubb
Copy link
Member Author

stubb commented Mar 14, 2016

From @prock-fife on April 16, 2012 0:17

This comment was posted by chewie

(In [3917]) - refactored ObjectEdit
- removed AnimationViewer component
- added new cell cost & cost id property (not loaded by trunk/ loaders)
- added cellstackposition property (not loaded by trunk/ loaders)
- plugin now also saves it's docking status in the editor settings file
- objects selected in the ObjectSelector now also update the ObjectEdit plugin
- removed all instance related options
- the plugin does however use the selected instance (if present) to show e.g. selected actions or rotations (not working for animated instances yet, as those need a facing location and don't react on instance.setRotation())
- image offset of animated objects can now be editted - the plugin applies the new offset to all animation frames
- saving animation image offsets does not work however (we need to migrate to new XML structure first)

  • small fix for InstanceHighlighter (deselects previous highlighted instances on new selections)
  • small fix for ObjectSelector - moved signal for onObjectSelector elsewhere (!= to Elsweyr ;-))
  • adjusted XMLObjectSaver to also save new object properties

related to , refs #685

@stubb
Copy link
Member Author

stubb commented Mar 14, 2016

From @prock-fife on April 17, 2012 22:1

(In [3919]) * Added InstanceHighlighter to settings-dist for the editor. It is now enabled by default. refs #685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant