Skip to content

Commit 5f2bcc5

Browse files
authored
Merge pull request #437 from fidelity-contributions/feat/capecpi-2422-expose-admin-cr
November Maintenence, expose admin clusterrole
2 parents c20c696 + 74f9427 commit 5f2bcc5

File tree

7 files changed

+41
-11
lines changed

7 files changed

+41
-11
lines changed

VERSION

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v0.3.44
1+
v0.3.45

chart/Chart.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ apiVersion: v2
22
description: A Helm chart for kraan controller
33
name: kraan-controller
44
type: application
5-
appVersion: v0.3.44
6-
version: v0.3.44
5+
appVersion: v0.3.45
6+
version: v0.3.45

chart/templates/gotk/rbac.yaml

+10-1
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,17 @@ metadata:
153153
roleRef:
154154
apiGroup: rbac.authorization.k8s.io
155155
kind: ClusterRole
156-
name: cluster-admin
156+
name: {{ .Values.gotk.rbac.adminClusterRole.name }}
157157
subjects:
158158
- kind: ServiceAccount
159159
name: fluxcd
160160
namespace: "{{ .Release.Namespace }}"
161+
{{ if .Values.gotk.rbac.adminClusterRole.rules }}
162+
---
163+
apiVersion: rbac.authorization.k8s.io/v1
164+
kind: ClusterRole
165+
metadata:
166+
name: {{ .Values.gotk.rbac.adminClusterRole.name }}
167+
rules:
168+
{{ .Values.gotk.rbac.adminClusterRole.rules | toYaml }}
169+
{{- end }}

chart/templates/kraan/rbac.yaml

+10-1
Original file line numberDiff line numberDiff line change
@@ -156,9 +156,18 @@ metadata:
156156
roleRef:
157157
apiGroup: rbac.authorization.k8s.io
158158
kind: ClusterRole
159-
name: cluster-admin
159+
name: {{ .Values.kraan.rbac.adminClusterRole.name }}
160160
subjects:
161161
- kind: ServiceAccount
162162
name: kraan
163163
namespace: {{.Release.Namespace}}
164+
{{ if .Values.kraan.rbac.adminClusterRole.rules }}
165+
---
166+
apiVersion: rbac.authorization.k8s.io/v1
167+
kind: ClusterRole
168+
metadata:
169+
name: {{ .Values.kraan.rbac.adminClusterRole.name }}
170+
rules:
171+
{{ .Values.kraan.rbac.adminClusterRole.rules | toYaml }}
172+
{{- end }}
164173
{{- end }}

chart/values.yaml

+12
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,12 @@ kraan:
1616
enabled: true
1717
rbac:
1818
enabled: true
19+
adminClusterRole:
20+
# admin ClusterRole to be used by the controller, default is cluster-admin
21+
name: "cluster-admin"
22+
# specify rules to create a ClusterRole
23+
# https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.31/#policyrule-v1-rbac-authorization-k8s-io
24+
rules: []
1925
netpolicy:
2026
enabled: true
2127
kraanController:
@@ -81,6 +87,12 @@ kraan:
8187
gotk:
8288
rbac:
8389
enabled: true
90+
adminClusterRole:
91+
# admin ClusterRole to be used by the controller, default is cluster-admin
92+
name: "cluster-admin"
93+
# specify rules to create a ClusterRole
94+
# https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.31/#policyrule-v1-rbac-authorization-k8s-io
95+
rules: []
8496
netpolicy:
8597
enabled: true
8698

go.mod

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ require (
1414
github.com/google/go-cmp v0.6.0
1515
github.com/paulcarlton-ww/goutils/pkg/testutils v0.1.42
1616
github.com/pkg/errors v0.9.1
17-
github.com/prometheus/client_golang v1.20.4
17+
github.com/prometheus/client_golang v1.20.5
1818
go.uber.org/zap v1.27.0
19-
golang.org/x/mod v0.21.0
19+
golang.org/x/mod v0.22.0
2020
k8s.io/api v0.31.1
2121
k8s.io/apiextensions-apiserver v0.31.1
2222
k8s.io/apimachinery v0.31.1

go.sum

+4-4
Original file line numberDiff line numberDiff line change
@@ -180,8 +180,8 @@ github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINE
180180
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
181181
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 h1:Jamvg5psRIccs7FGNTlIRMkT8wgtp5eCXdBlqhYGL6U=
182182
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
183-
github.com/prometheus/client_golang v1.20.4 h1:Tgh3Yr67PaOv/uTqloMsCEdeuFTatm5zIq5+qNN23vI=
184-
github.com/prometheus/client_golang v1.20.4/go.mod h1:PIEt8X02hGcP8JWbeHyeZ53Y/jReSnHgO035n//V5WE=
183+
github.com/prometheus/client_golang v1.20.5 h1:cxppBPuYhUnsO6yo/aoRol4L7q7UFfdm+bR9r+8l63Y=
184+
github.com/prometheus/client_golang v1.20.5/go.mod h1:PIEt8X02hGcP8JWbeHyeZ53Y/jReSnHgO035n//V5WE=
185185
github.com/prometheus/client_model v0.0.0-20190812154241-14fe0d1b01d4/go.mod h1:xMI15A0UPsDsEKsMN9yxemIoYk6Tm2C1GtYGdfGttqA=
186186
github.com/prometheus/client_model v0.6.1 h1:ZKSh/rekM+n3CeS952MLRAdFwIKqeY8b62p8ais2e9E=
187187
github.com/prometheus/client_model v0.6.1/go.mod h1:OrxVMOVHjw3lKMa8+x6HeMGkHMQyHDk9E3jmP2AmGiY=
@@ -229,8 +229,8 @@ golang.org/x/lint v0.0.0-20190313153728-d0100b6bd8b3/go.mod h1:6SW0HCj/g11FgYtHl
229229
golang.org/x/mod v0.2.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
230230
golang.org/x/mod v0.3.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
231231
golang.org/x/mod v0.4.2/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
232-
golang.org/x/mod v0.21.0 h1:vvrHzRwRfVKSiLrG+d4FMl/Qi4ukBCE6kZlTUkDYRT0=
233-
golang.org/x/mod v0.21.0/go.mod h1:6SkKJ3Xj0I0BrPOZoBy3bdMptDDU9oJrpohJ3eWZ1fY=
232+
golang.org/x/mod v0.22.0 h1:D4nJWe9zXqHOmWqj4VMOJhvzj7bEZg4wEYa759z1pH4=
233+
golang.org/x/mod v0.22.0/go.mod h1:6SkKJ3Xj0I0BrPOZoBy3bdMptDDU9oJrpohJ3eWZ1fY=
234234
golang.org/x/net v0.0.0-20180724234803-3673e40ba225/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
235235
golang.org/x/net v0.0.0-20180826012351-8a410e7b638d/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
236236
golang.org/x/net v0.0.0-20180906233101-161cd47e91fd/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=

0 commit comments

Comments
 (0)