Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choppy flash animation on sway 1.10 #87

Closed
minhduc0711 opened this issue Jan 5, 2025 · 5 comments
Closed

Choppy flash animation on sway 1.10 #87

minhduc0711 opened this issue Jan 5, 2025 · 5 comments

Comments

@minhduc0711
Copy link

The flash animation becomes choppy after I upgraded sway from 1.9 -> 1.10 (wlroots 0.17 -> 0.18).

bad.mp4

I ran flashfocus -v DEBUG, but I didn't see any interesting messages in the log.
It no longer happens when I downgrade sway & wlroots to 1.9 & 0.17 respectively:

good.mp4

Could you give me some pointers on what might have happened? I'd be happy to do some digging on my own.

@fennerm
Copy link
Owner

fennerm commented Jan 14, 2025

Thanks for reporting @minhduc0711. I'm not sure what could cause this tbh. I'm on vacation for the next few weeks but I'll see if I can reproduce when I get back. All the code that interfaces with sway is here https://github.com/fennerm/flashfocus/blob/master/src/flashfocus/display_protocols/sway.py.

@fennerm
Copy link
Owner

fennerm commented Feb 18, 2025

Sorry to be slow on this one. I've been able to reproduce and am looking into a fix.

@fennerm
Copy link
Owner

fennerm commented Feb 18, 2025

Confirmed this seems to be an issue introduced in sway v1.10. I opened a ticket upstream - swaywm/sway#8580

@fennerm fennerm closed this as completed Feb 25, 2025
@fennerm
Copy link
Owner

fennerm commented Feb 25, 2025

Fix should be included in the next sway release

@minhduc0711
Copy link
Author

Thank you for looking into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants