Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github黑话/code review 行话 #16

Open
fengzhao opened this issue Jul 11, 2021 · 0 comments
Open

github黑话/code review 行话 #16

fengzhao opened this issue Jul 11, 2021 · 0 comments

Comments

@fengzhao
Copy link
Owner

简称 全称(解释)
LGTM Looks Good To Me「对我来说,还不错」表示认可这次PR,同意merge合并代码到远程仓库
ASAP As Soon As Possible「尽快」
ACK Acknowledgement「承认,确认,同意」i.e. agreed/accepted change
NACK/NAK Negative acknowledgement「不同意」 i.e. disagree with change and/or concept
RFC Request For Comments「请求进行讨论」 i.e. I think this is a good idea, lets discuss
WIP Work In Progress 「进展中」常见词汇,这里作为 Best Practice 单独提出来,主要针对改动较多的 PR,可以先提交部分,标题或 Tag 加上 WIP,表示尚未完成,这样别人可以先 review 已提交的部分
AFAIK/AFAICT As Far As I Know / Can Tell 「据我所知;就我所知」
IIRC If I Recall Correctly「如果我没有记错的话」
IANAL I am not a lawyer , but I smell licensing issues「-」
IMO In My Opinion 「在我看来」
TL;DR Too Long; Didn’t Read 「太长懒得看」README 文档常见。
PR Pull Request「合并请求」
CR Code Review 「代码审查」
PTAL Please Take A Look.「你来瞅瞅?」用来提示别人来看一下
TBR To Be Reviewed「提示维护者进行 review」
TBD To Be Done(or Defined/Discussed/Decided/Determined). 「未完成,将被做」根据语境不同意义有所区别,但一般都是还没搞定的意思。
TBH To Be Honest 「老实说」
atm at the moment 「现阶段」

@fengzhao fengzhao changed the title code review 行话 github黑话code review 行话 Mar 22, 2024
@fengzhao fengzhao changed the title github黑话code review 行话 github黑话/code review 行话 Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant