Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Premature line break leaves unwanted space #9

Open
WardCunningham opened this issue Jul 30, 2015 · 1 comment
Open

Premature line break leaves unwanted space #9

WardCunningham opened this issue Jul 30, 2015 · 1 comment

Comments

@WardCunningham
Copy link
Member

A line break is inserted into the rendered list of flags when the 18th flag is found. If a line of flags has exactly 18 flags then an unnecessary and unattractive br produces excess line spacing. See source

I noticed this issue while looking for stray newlines in the roster produced while scraping the federation.

image

A better algorithm would terminate the first line when the 19th flag was encountered. Even more complex logic could then omit the br should the line be found to stand at 18 when advancing to a new section.

This code has other problems in some versions of ie where 18 is one too many flags for a line. I note this spacing problem here in case anyone ever tackles the other count based line breaking limitations of this plugin.

@WardCunningham
Copy link
Member Author

We're much more likely to see this problem with the Visible Federation scrape result where the white space has strong semantics. See WardCunningham/search#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant