Fixed test_retrieve_online_milvus_documents

Signed-off-by: ntkathole <[email protected]>

Author: ntkathole

sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py

@@ -563,11 +563,16 @@ def retrieve_online_documents_v2(
                         field, PrimitiveFeastType.INVALID
                     ) in [
                         PrimitiveFeastType.STRING,
+                        PrimitiveFeastType.BYTES,
+                    ]:
+                        res[field] = ValueProto(string_val=str(field_value))
+                    elif entity_name_feast_primitive_type_map.get(
+                        field, PrimitiveFeastType.INVALID
+                    ) in [
                         PrimitiveFeastType.INT64,
                         PrimitiveFeastType.INT32,
-                        PrimitiveFeastType.BYTES,
                     ]:
-                        res[field] = ValueProto(string_val=field_value)
+                        res[field] = ValueProto(int64_val=int(field_value))
                     elif field == composite_key_name:
                         pass
                     elif isinstance(field_value, bytes):

sdk/python/tests/integration/feature_repos/repo_configuration.py

@@ -89,7 +89,7 @@
 )
 
 DYNAMO_CONFIG = {"type": "dynamodb", "region": "us-west-2"}
-MILVUS_CONFIG = {"type": "milvus"}
+MILVUS_CONFIG = {"type": "milvus", "embedding_dim": "2"}
 REDIS_CONFIG = {"type": "redis", "connection_string": "localhost:6379,db=0"}
 REDIS_CLUSTER_CONFIG = {
     "type": "redis",
@@ -564,8 +564,7 @@ def construct_test_environment(
             path=str(Path(repo_dir_name) / "registry.db"),
             cache_ttl_seconds=1,
         )
-
-    if test_repo_config.online_store in ["milvus", "pgvector", "qdrant"]:
+    if test_repo_config.online_store.get("type") in ["milvus", "pgvector", "qdrant"]:
         entity_key_serialization_version = 3
 
     environment_params = {

sdk/python/tests/integration/feature_repos/universal/feature_views.py

@@ -160,12 +160,6 @@ def create_item_embeddings_feature_view(source, infer_features: bool = False):
         schema=None
         if infer_features
         else [
-            Field(
-                name="embedding_double",
-                dtype=Array(Float64),
-                vector_index=True,
-                vector_search_metric="L2",
-            ),
             Field(
                 name="embedding_float",
                 dtype=Array(Float32),

sdk/python/tests/integration/online_store/test_universal_online.py

@@ -905,8 +905,7 @@ def test_retrieve_online_milvus_documents(environment, fake_document_data):
     item_embeddings_feature_view = create_item_embeddings_feature_view(data_source)
     fs.apply([item_embeddings_feature_view, item()])
     fs.write_to_online_store("item_embeddings", df)
-    documents = fs.retrieve_online_documents(
-        feature=None,
+    documents = fs.retrieve_online_documents_v2(
         features=[
             "item_embeddings:embedding_float",
             "item_embeddings:item_id",