Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder name with emoji causes compression errors. #78

Open
2 tasks done
Niranjan-A-S opened this issue Jul 9, 2024 · 6 comments
Open
2 tasks done

Folder name with emoji causes compression errors. #78

Niranjan-A-S opened this issue Jul 9, 2024 · 6 comments

Comments

@Niranjan-A-S
Copy link

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the bug has not already been reported

Fastify version

4.28.0

Plugin version

No response

Node.js version

20.14

Operating system

Windows

Operating system version (i.e. 20.04, 11.3, 10)

10

Description

The emoji "☃" in the "test/fixtures/snow ☃" is causing issues while trying to compress the node_modules of the application using the window's native compress tool.

Link to code that reproduces the bug

No response

Expected Behavior

No response

@mcollina
Copy link
Member

mcollina commented Jul 9, 2024

Thanks for reporting!

Can you provide steps to reproduce? We often need a reproducible example, e.g. some code that allows someone else to recreate your problem by just copying and pasting it. If it involves more than a couple of different file, create a new repository on GitHub and add a link to that.

@Niranjan-A-S
Copy link
Author

Please follow the steps to reproduce.

  • Make sure you have @fastify/send in your node_modules.
  • Try to compress node_modules folder directly or the parent folder with the windows native compress tool. (Don't use 7-Zip or any other tools.)
  • You will be prevented from completing the action with a prompt. Please find the snapshot attached.

Screenshot 2024-07-09 153619

@Eomm
Copy link
Member

Eomm commented Jul 9, 2024

Duplicate #51 ?

I mean, save time by ignoring test/ folders

@Niranjan-A-S
Copy link
Author

Requires an extra layer of step to remove the test folder during the build process. The "snow ☃" can be renamed right?

@jsumners
Copy link
Member

jsumners commented Jul 9, 2024

Requires an extra layer of step to remove the test folder during the build process. The "snow ☃" can be renamed right?

No. 8a44fe6

@Niranjan-A-S
Copy link
Author

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants