You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
eps: A threshold for clipping the squared norm of the rotation logarithm
to avoid division by zero in the singular case.
cos_bound: Clamps the cosine of the rotation angle to
[-1 + cos_bound, 3 - cos_bound] to avoid non-finite outputs.
The non-finite outputs can be caused by passing small rotation angles
to the `acos` function in `so3_rotation_angle` of `so3_log_map`.
However, following #1609 and 292acc7 it appeared that eps and cos_bound are only retained for backwards compatibility in so3_log_map (Note the o instead of e). This is made clear in the corresponding documentation:
Reading through the documentation for
se3_log_map
, I was under the impression thateps
andcos_bound
were important for numerical stability:pytorch3d/pytorch3d/transforms/se3.py
Lines 142 to 147 in 43cd681
However, following #1609 and 292acc7 it appeared that
eps
andcos_bound
are only retained for backwards compatibility inso3_log_map
(Note theo
instead ofe
). This is made clear in the corresponding documentation:pytorch3d/pytorch3d/transforms/so3.py
Lines 184 to 185 in 43cd681
Now, given that
se3_log_map
callsso3_log_map
,pytorch3d/pytorch3d/transforms/se3.py
Line 173 in 43cd681
I believe the deprecation of
eps
andcos_bound
should also be highlighted in teh documentation ofse3_log_map
.The text was updated successfully, but these errors were encountered: