Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZSTD_DICTSIZE_MIN is referenced in documentation but not defined #4142

Closed
mvhooren opened this issue Sep 19, 2024 · 1 comment · Fixed by #4143
Closed

ZSTD_DICTSIZE_MIN is referenced in documentation but not defined #4142

mvhooren opened this issue Sep 19, 2024 · 1 comment · Fixed by #4143
Assignees
@Cyan4973
Labels
documentation

Comments

@mvhooren
Copy link

The documentation of ZDICT_finalizeDictionary says:

*maxDictSize must be >= max(dictContentSize, ZSTD_DICTSIZE_MIN).

But ZSTD_DICTSIZE_MIN is not defined anywhere.
What is the actual minimum dictionary size?
@Cyan4973
Copy link
Contributor

It's a typo: it's actually ZDICT_DICTSIZE_MIN, which is defined in the same file

@Cyan4973 Cyan4973 self-assigned this Sep 19, 2024
@Cyan4973 Cyan4973 mentioned this issue Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cyan4973 Cyan4973

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix doc nit: ZDICT_DICTSIZE_MIN facebook/zstd
2 participants
@Cyan4973 @mvhooren