Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mononoke binaries aren't actually published #922

Closed
thoughtpolice opened this issue Jul 18, 2024 · 6 comments
Closed

Mononoke binaries aren't actually published #922

thoughtpolice opened this issue Jul 18, 2024 · 6 comments

Comments

@thoughtpolice
Copy link

Hi,

I saw the announcement in the README about the Mononoke backend working. That's exciting! I'm happy to dig into it myself and play around, but...

It looks like the binary builds aren't working — for Mononoke, specifically. They do work for EdenFS. Note that none of the runs here have artifacts published and there's even a warning from the upload-artifact action that no paths were found to upload: https://github.com/facebook/sapling/actions/workflows/mononoke_linux.yml

Also: is a new Sapling client required to interface with Mononoke? I assume so, but I know nothing. Should there be a new release done in order to allow testing the two?

@Matthew-Benson
Copy link

I was able to follow the same steps for Mononoke's build process that's running in CI and got a mononoke binary, but I'm fairly sure the artifact path in this job step is wrong and that's why nothing gets uploaded. I'm not sure if that's intentional or not.

It has been a while, but I have in my notes that the path for the mononoke binary was /tmp/fbcode_builder_getdeps-ZhomeZrunnerZsaplingZbuildZfbcode_builder/installed/mononoke/bin/mononoke.

There's some detail about it in #812.

@mzr mzr closed this as completed Aug 23, 2024
@mzr mzr reopened this Aug 23, 2024
@mzr
Copy link
Contributor

mzr commented Aug 23, 2024

The builds of Mononoke aren't as well supported as builds of Sapling at this time. I don't recall we tried full setup of EdenFS, Monoonke and Sapling together outside of the internal use at Meta, but I might be wrong on this one.
As for tinkering at the moment, perhaps @ahornby who has done some work around this might be better positioned to give some advice.

Also: is a new Sapling client required to interface with Mononoke?

The best supported use-case right now is Sapling as client for git repositories. You can read more about this in https://sapling-scm.com/.

@thoughtpolice
Copy link
Author

thoughtpolice commented Aug 23, 2024

Oh, I've used sl quite a bit for Git! But it was more that this commit that flew by recently in the Jujutsu Discord is what had me interested (as we are interested in our own non-Git backend): e2f00fa

I knew that the binaries weren't previously supported, but it at least seemed like there were supposed to be (undocumented) binaries published via actions. Hence the original issue. :) I'm perfectly happy trudging around on my own otherwise, though.

@ahornby
Copy link
Contributor

ahornby commented Aug 28, 2024

@thoughtpolice yep, you'll need to build your own binaries, looks like the paths might not be quite right to capture the ones actions builds. I think mononoke is quite likely to start if you manage to decipher the mysql and s3 bucket configs

@ahornby
Copy link
Contributor

ahornby commented Sep 18, 2024

Sapling thrift client build added in #950

@ahornby
Copy link
Contributor

ahornby commented Sep 18, 2024

Mononoke integration tests using it in #951

ahornby added a commit to ahornby/sapling that referenced this issue Sep 19, 2024
Summary:
fix getdeps generate-github-actions by adding missing process_project_dir_arguments.  Without this couldn't specify any project_install_prefix other that the default /usr/local

mononoke installs directly to getdeps inst dir so needs a project_install_prefix of / for the artifact discovery to work

regenerated the gh actions with `python3 fbcode/opensource/fbcode_builder/getdeps.py generate-github-actions mononoke --os-type=linux --allow-system-packages --output-dir fbcode/eden/oss/.github/workflows --job-file-prefix mononoke_ --job-name-prefix "Mononoke " --free-up-disk --project-install-prefix mononoke:/`

Resolves facebook#922

Differential Revision: D63031271
facebook-github-bot pushed a commit to facebook/fbthrift that referenced this issue Sep 20, 2024
Summary:
X-link: facebook/sapling#952

fix getdeps generate-github-actions by adding missing process_project_dir_arguments.  Without this couldn't specify any project_install_prefix other that the default /usr/local

mononoke installs directly to getdeps inst dir so needs a project_install_prefix of / for the artifact discovery to work

regenerated the gh actions with `python3 fbcode/opensource/fbcode_builder/getdeps.py generate-github-actions mononoke --os-type=linux --allow-system-packages --output-dir fbcode/eden/oss/.github/workflows --job-file-prefix mononoke_ --job-name-prefix "Mononoke " --free-up-disk --project-install-prefix mononoke:/`

Resolves facebook/sapling#922

Reviewed By: bigfootjon

Differential Revision: D63031271

fbshipit-source-id: 768a4fbd7617c6061eca66b4d916ac25a4b66be9
facebook-github-bot pushed a commit to facebook/folly that referenced this issue Sep 20, 2024
Summary:
X-link: facebook/sapling#952

fix getdeps generate-github-actions by adding missing process_project_dir_arguments.  Without this couldn't specify any project_install_prefix other that the default /usr/local

mononoke installs directly to getdeps inst dir so needs a project_install_prefix of / for the artifact discovery to work

regenerated the gh actions with `python3 fbcode/opensource/fbcode_builder/getdeps.py generate-github-actions mononoke --os-type=linux --allow-system-packages --output-dir fbcode/eden/oss/.github/workflows --job-file-prefix mononoke_ --job-name-prefix "Mononoke " --free-up-disk --project-install-prefix mononoke:/`

Resolves facebook/sapling#922

Reviewed By: bigfootjon

Differential Revision: D63031271

fbshipit-source-id: 768a4fbd7617c6061eca66b4d916ac25a4b66be9
facebook-github-bot pushed a commit to facebook/mvfst that referenced this issue Sep 20, 2024
Summary:
X-link: facebook/sapling#952

fix getdeps generate-github-actions by adding missing process_project_dir_arguments.  Without this couldn't specify any project_install_prefix other that the default /usr/local

mononoke installs directly to getdeps inst dir so needs a project_install_prefix of / for the artifact discovery to work

regenerated the gh actions with `python3 fbcode/opensource/fbcode_builder/getdeps.py generate-github-actions mononoke --os-type=linux --allow-system-packages --output-dir fbcode/eden/oss/.github/workflows --job-file-prefix mononoke_ --job-name-prefix "Mononoke " --free-up-disk --project-install-prefix mononoke:/`

Resolves facebook/sapling#922

Reviewed By: bigfootjon

Differential Revision: D63031271

fbshipit-source-id: 768a4fbd7617c6061eca66b4d916ac25a4b66be9
facebook-github-bot pushed a commit to facebook/openr that referenced this issue Sep 20, 2024
Summary:
X-link: facebook/sapling#952

fix getdeps generate-github-actions by adding missing process_project_dir_arguments.  Without this couldn't specify any project_install_prefix other that the default /usr/local

mononoke installs directly to getdeps inst dir so needs a project_install_prefix of / for the artifact discovery to work

regenerated the gh actions with `python3 fbcode/opensource/fbcode_builder/getdeps.py generate-github-actions mononoke --os-type=linux --allow-system-packages --output-dir fbcode/eden/oss/.github/workflows --job-file-prefix mononoke_ --job-name-prefix "Mononoke " --free-up-disk --project-install-prefix mononoke:/`

Resolves facebook/sapling#922

Reviewed By: bigfootjon

Differential Revision: D63031271

fbshipit-source-id: 768a4fbd7617c6061eca66b4d916ac25a4b66be9
facebook-github-bot pushed a commit to facebook/proxygen that referenced this issue Sep 20, 2024
Summary:
X-link: facebook/sapling#952

fix getdeps generate-github-actions by adding missing process_project_dir_arguments.  Without this couldn't specify any project_install_prefix other that the default /usr/local

mononoke installs directly to getdeps inst dir so needs a project_install_prefix of / for the artifact discovery to work

regenerated the gh actions with `python3 fbcode/opensource/fbcode_builder/getdeps.py generate-github-actions mononoke --os-type=linux --allow-system-packages --output-dir fbcode/eden/oss/.github/workflows --job-file-prefix mononoke_ --job-name-prefix "Mononoke " --free-up-disk --project-install-prefix mononoke:/`

Resolves facebook/sapling#922

Reviewed By: bigfootjon

Differential Revision: D63031271

fbshipit-source-id: 768a4fbd7617c6061eca66b4d916ac25a4b66be9
facebook-github-bot pushed a commit to facebook/wangle that referenced this issue Sep 20, 2024
Summary:
X-link: facebook/sapling#952

fix getdeps generate-github-actions by adding missing process_project_dir_arguments.  Without this couldn't specify any project_install_prefix other that the default /usr/local

mononoke installs directly to getdeps inst dir so needs a project_install_prefix of / for the artifact discovery to work

regenerated the gh actions with `python3 fbcode/opensource/fbcode_builder/getdeps.py generate-github-actions mononoke --os-type=linux --allow-system-packages --output-dir fbcode/eden/oss/.github/workflows --job-file-prefix mononoke_ --job-name-prefix "Mononoke " --free-up-disk --project-install-prefix mononoke:/`

Resolves facebook/sapling#922

Reviewed By: bigfootjon

Differential Revision: D63031271

fbshipit-source-id: 768a4fbd7617c6061eca66b4d916ac25a4b66be9
facebook-github-bot pushed a commit to facebook/hhvm that referenced this issue Sep 20, 2024
Summary:
X-link: facebook/sapling#952

fix getdeps generate-github-actions by adding missing process_project_dir_arguments.  Without this couldn't specify any project_install_prefix other that the default /usr/local

mononoke installs directly to getdeps inst dir so needs a project_install_prefix of / for the artifact discovery to work

regenerated the gh actions with `python3 fbcode/opensource/fbcode_builder/getdeps.py generate-github-actions mononoke --os-type=linux --allow-system-packages --output-dir fbcode/eden/oss/.github/workflows --job-file-prefix mononoke_ --job-name-prefix "Mononoke " --free-up-disk --project-install-prefix mononoke:/`

Resolves facebook/sapling#922

Reviewed By: bigfootjon

Differential Revision: D63031271

fbshipit-source-id: 768a4fbd7617c6061eca66b4d916ac25a4b66be9
facebook-github-bot pushed a commit to facebook/watchman that referenced this issue Sep 20, 2024
Summary:
X-link: facebook/sapling#952

fix getdeps generate-github-actions by adding missing process_project_dir_arguments.  Without this couldn't specify any project_install_prefix other that the default /usr/local

mononoke installs directly to getdeps inst dir so needs a project_install_prefix of / for the artifact discovery to work

regenerated the gh actions with `python3 fbcode/opensource/fbcode_builder/getdeps.py generate-github-actions mononoke --os-type=linux --allow-system-packages --output-dir fbcode/eden/oss/.github/workflows --job-file-prefix mononoke_ --job-name-prefix "Mononoke " --free-up-disk --project-install-prefix mononoke:/`

Resolves facebook/sapling#922

Reviewed By: bigfootjon

Differential Revision: D63031271

fbshipit-source-id: 768a4fbd7617c6061eca66b4d916ac25a4b66be9
facebook-github-bot pushed a commit that referenced this issue Sep 20, 2024
Summary:
Pull Request resolved: #952

fix getdeps generate-github-actions by adding missing process_project_dir_arguments.  Without this couldn't specify any project_install_prefix other that the default /usr/local

mononoke installs directly to getdeps inst dir so needs a project_install_prefix of / for the artifact discovery to work

regenerated the gh actions with `python3 fbcode/opensource/fbcode_builder/getdeps.py generate-github-actions mononoke --os-type=linux --allow-system-packages --output-dir fbcode/eden/oss/.github/workflows --job-file-prefix mononoke_ --job-name-prefix "Mononoke " --free-up-disk --project-install-prefix mononoke:/`

Resolves #922

Reviewed By: bigfootjon

Differential Revision: D63031271

fbshipit-source-id: 768a4fbd7617c6061eca66b4d916ac25a4b66be9
facebook-github-bot pushed a commit to facebookexperimental/rust-shed that referenced this issue Sep 20, 2024
Summary:
X-link: facebook/sapling#952

fix getdeps generate-github-actions by adding missing process_project_dir_arguments.  Without this couldn't specify any project_install_prefix other that the default /usr/local

mononoke installs directly to getdeps inst dir so needs a project_install_prefix of / for the artifact discovery to work

regenerated the gh actions with `python3 fbcode/opensource/fbcode_builder/getdeps.py generate-github-actions mononoke --os-type=linux --allow-system-packages --output-dir fbcode/eden/oss/.github/workflows --job-file-prefix mononoke_ --job-name-prefix "Mononoke " --free-up-disk --project-install-prefix mononoke:/`

Resolves facebook/sapling#922

Reviewed By: bigfootjon

Differential Revision: D63031271

fbshipit-source-id: 768a4fbd7617c6061eca66b4d916ac25a4b66be9
facebook-github-bot pushed a commit to facebook/fboss that referenced this issue Sep 20, 2024
Summary:
X-link: facebook/sapling#952

fix getdeps generate-github-actions by adding missing process_project_dir_arguments.  Without this couldn't specify any project_install_prefix other that the default /usr/local

mononoke installs directly to getdeps inst dir so needs a project_install_prefix of / for the artifact discovery to work

regenerated the gh actions with `python3 fbcode/opensource/fbcode_builder/getdeps.py generate-github-actions mononoke --os-type=linux --allow-system-packages --output-dir fbcode/eden/oss/.github/workflows --job-file-prefix mononoke_ --job-name-prefix "Mononoke " --free-up-disk --project-install-prefix mononoke:/`

Resolves facebook/sapling#922

Reviewed By: bigfootjon

Differential Revision: D63031271

fbshipit-source-id: 768a4fbd7617c6061eca66b4d916ac25a4b66be9
facebook-github-bot pushed a commit to facebookexperimental/edencommon that referenced this issue Sep 20, 2024
Summary:
X-link: facebook/sapling#952

fix getdeps generate-github-actions by adding missing process_project_dir_arguments.  Without this couldn't specify any project_install_prefix other that the default /usr/local

mononoke installs directly to getdeps inst dir so needs a project_install_prefix of / for the artifact discovery to work

regenerated the gh actions with `python3 fbcode/opensource/fbcode_builder/getdeps.py generate-github-actions mononoke --os-type=linux --allow-system-packages --output-dir fbcode/eden/oss/.github/workflows --job-file-prefix mononoke_ --job-name-prefix "Mononoke " --free-up-disk --project-install-prefix mononoke:/`

Resolves facebook/sapling#922

Reviewed By: bigfootjon

Differential Revision: D63031271

fbshipit-source-id: 768a4fbd7617c6061eca66b4d916ac25a4b66be9
facebook-github-bot pushed a commit to facebookexperimental/moxygen that referenced this issue Sep 20, 2024
Summary:
X-link: facebook/sapling#952

fix getdeps generate-github-actions by adding missing process_project_dir_arguments.  Without this couldn't specify any project_install_prefix other that the default /usr/local

mononoke installs directly to getdeps inst dir so needs a project_install_prefix of / for the artifact discovery to work

regenerated the gh actions with `python3 fbcode/opensource/fbcode_builder/getdeps.py generate-github-actions mononoke --os-type=linux --allow-system-packages --output-dir fbcode/eden/oss/.github/workflows --job-file-prefix mononoke_ --job-name-prefix "Mononoke " --free-up-disk --project-install-prefix mononoke:/`

Resolves facebook/sapling#922

Reviewed By: bigfootjon

Differential Revision: D63031271

fbshipit-source-id: 768a4fbd7617c6061eca66b4d916ac25a4b66be9
facebook-github-bot pushed a commit to facebookincubator/katran that referenced this issue Sep 20, 2024
Summary:
X-link: facebook/sapling#952

fix getdeps generate-github-actions by adding missing process_project_dir_arguments.  Without this couldn't specify any project_install_prefix other that the default /usr/local

mononoke installs directly to getdeps inst dir so needs a project_install_prefix of / for the artifact discovery to work

regenerated the gh actions with `python3 fbcode/opensource/fbcode_builder/getdeps.py generate-github-actions mononoke --os-type=linux --allow-system-packages --output-dir fbcode/eden/oss/.github/workflows --job-file-prefix mononoke_ --job-name-prefix "Mononoke " --free-up-disk --project-install-prefix mononoke:/`

Resolves facebook/sapling#922

Reviewed By: bigfootjon

Differential Revision: D63031271

fbshipit-source-id: 768a4fbd7617c6061eca66b4d916ac25a4b66be9
facebook-github-bot pushed a commit to facebookincubator/hsthrift that referenced this issue Sep 20, 2024
Summary:
X-link: facebook/sapling#952

fix getdeps generate-github-actions by adding missing process_project_dir_arguments.  Without this couldn't specify any project_install_prefix other that the default /usr/local

mononoke installs directly to getdeps inst dir so needs a project_install_prefix of / for the artifact discovery to work

regenerated the gh actions with `python3 fbcode/opensource/fbcode_builder/getdeps.py generate-github-actions mononoke --os-type=linux --allow-system-packages --output-dir fbcode/eden/oss/.github/workflows --job-file-prefix mononoke_ --job-name-prefix "Mononoke " --free-up-disk --project-install-prefix mononoke:/`

Resolves facebook/sapling#922

Reviewed By: bigfootjon

Differential Revision: D63031271

fbshipit-source-id: 768a4fbd7617c6061eca66b4d916ac25a4b66be9
facebook-github-bot pushed a commit to facebookincubator/fizz that referenced this issue Sep 20, 2024
Summary:
X-link: facebook/sapling#952

fix getdeps generate-github-actions by adding missing process_project_dir_arguments.  Without this couldn't specify any project_install_prefix other that the default /usr/local

mononoke installs directly to getdeps inst dir so needs a project_install_prefix of / for the artifact discovery to work

regenerated the gh actions with `python3 fbcode/opensource/fbcode_builder/getdeps.py generate-github-actions mononoke --os-type=linux --allow-system-packages --output-dir fbcode/eden/oss/.github/workflows --job-file-prefix mononoke_ --job-name-prefix "Mononoke " --free-up-disk --project-install-prefix mononoke:/`

Resolves facebook/sapling#922

Reviewed By: bigfootjon

Differential Revision: D63031271

fbshipit-source-id: 768a4fbd7617c6061eca66b4d916ac25a4b66be9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants