- support client 3d on concrete objects

Reviewed By: tyao1

Differential Revision: D71421963

fbshipit-source-id: 6c0f72775ba792055ca66195d7a2691ee669493c

Author: lynnshaoyu

compiler/crates/relay-transforms/src/match_/match_transform.rs

@@ -1104,12 +1104,23 @@ fn validate_parent_type_of_fragment_with_read_time_resolver(
             transform.relay_resolver_model_unions.insert(id);
         }
         Type::Object(id) => {
-            return Err(Diagnostic::error(
-                ValidationMessage::InvalidModuleOnConcreteParentType {
-                    object_name: transform.program.schema.object(id).name.item,
-                },
-                spread.fragment.location,
-            ));
+            let object_has_read_time_resolver = transform
+                .program
+                .schema
+                .object(id)
+                .directives
+                .named(*RELAY_RESOLVER_MODEL_DIRECTIVE_NAME)
+                .is_some();
+
+            if !object_has_read_time_resolver {
+                return Err(Diagnostic::error(
+                    ValidationMessage::MissingRelayResolverModelForObject {
+                        spread_name: spread.fragment.item,
+                        object: transform.program.schema.object(id).name.item,
+                    },
+                    spread.fragment.location,
+                ));
+            }
         }
         Type::Enum(_) | Type::Scalar(_) | Type::InputObject(_) => {
             panic!(

compiler/crates/relay-transforms/src/match_/validation_message.rs

@@ -137,7 +137,10 @@ pub enum ValidationMessage {
     },
 
     #[error(
-        "@module was used on a fragment with a concrete parent type: '{object_name}'. The parent type should be an interface or union."
+        "Invalid fragment spread '...{spread_name}'. Object '{object}' should be backed by a relay resolver model."
     )]
-    InvalidModuleOnConcreteParentType { object_name: ObjectName },
+    MissingRelayResolverModelForObject {
+        spread_name: FragmentDefinitionName,
+        object: ObjectName,
+    },
 }

compiler/crates/relay-transforms/tests/match_transform_client_resolver/fixtures/client-3D-module-on-concrete-parent-type.invalid.expected

@@ -1,5 +1,4 @@
 ==================================== INPUT ====================================
-# expected-to-throw
 fragment NameRendererFragment on Persona {
   id
   basicUser {
@@ -24,11 +23,37 @@ type BasicUser @__RelayResolverModel {
   address: String
   __relay_model_instance: RelayResolverValue @relay_resolver(import_path: "ClientUserResolver", fragment_name: "ClientUser__id", inject_fragment_data: "id")
 }
-==================================== ERROR ====================================
-✖︎ @module was used on a fragment with a concrete parent type: 'BasicUser'. The parent type should be an interface or union.
+==================================== OUTPUT ===================================
+fragment ClientUser_Fragment on BasicUser {
+  name
+  address
+}
 
-  client-3D-module-on-concrete-parent-type.invalid.graphql:5:8
-    4 │   basicUser {
-    5 │     ...ClientUser_Fragment @module(name: "ClientUser.react")
-      │        ^^^^^^^^^^^^^^^^^^^
-    6 │   }
+fragment NameRendererFragment on Persona {
+  id
+  basicUser {
+    ... on BasicUser {
+      ... on BasicUser @__ModuleMetadata
+      # ModuleMetadata {
+      #     location: client-3D-module-on-concrete-parent-type.invalid.graphql:89:96,
+      #     key: "NameRendererFragment",
+      #     module_id: "NameRendererFragment.basicUser",
+      #     module_name: "ClientUser.react",
+      #     source_document_name: FragmentDefinitionName(
+      #         FragmentDefinitionName(
+      #             "NameRendererFragment",
+      #         ),
+      #     ),
+      #     read_time_resolvers: true,
+      #     fragment_name: FragmentDefinitionName(
+      #         "ClientUser_Fragment",
+      #     ),
+      #     fragment_source_location: client-3D-module-on-concrete-parent-type.invalid.graphql:139:158,
+      #     no_inline: false,
+      # }
+       {
+        ...ClientUser_Fragment
+      }
+    }
+  }
+}

compiler/crates/relay-transforms/tests/match_transform_client_resolver/fixtures/client-3D-module-on-concrete-parent-type.invalid.graphql

@@ -1,4 +1,3 @@
-# expected-to-throw
 fragment NameRendererFragment on Persona {
   id
   basicUser {