Split build_mode in LIT config to debug_options and slow_debug

Summary:
Originally `build_mode` controls `debug_options` and `slow_debug`.
Determine these two flags directly in CMake and remove `build_mode`.

Reviewed By: neildhar

Differential Revision: D60076693

fbshipit-source-id: cd5f730be6f827ad352e9ef471205740557d02cf

Author: lavenzg

CMakeLists.txt

@@ -800,7 +800,8 @@ if(HERMES_ENABLE_TEST_SUITE)
     hbcdump=${HERMES_TOOLS_OUTPUT_DIR}/hbcdump
     hbc-deltaprep=${HERMES_TOOLS_OUTPUT_DIR}/hbc-deltaprep
     hbc_diff=${HERMES_TOOLS_OUTPUT_DIR}/hbc-diff
-    build_mode="$<IF:$<CONFIG:Debug>,dbg,opt>"
+    slow_debug=$<IF:$<CONFIG:Debug>,${HERMES_SLOW_DEBUG},OFF>
+    debug_options=$<IF:$<CONFIG:Debug>,ON,OFF>
     exception_on_oom_enabled=${HERMESVM_EXCEPTION_ON_OOM}
     node_hermes_enabled_flag=${HERMES_BUILD_NODE_HERMES}
     node-hermes=${HERMES_TOOLS_OUTPUT_DIR}/node-hermes

cmake/modules/Lit.cmake

@@ -16,9 +16,6 @@ function(add_lit_target target comment)
   cmake_parse_arguments(ARG "" "" "PARAMS;DEPENDS;ARGS" ${ARGN})
   set(LIT_ARGS "${ARG_ARGS} ${LLVH_LIT_ARGS}")
   separate_arguments(LIT_ARGS)
-  if (NOT CMAKE_CFG_INTDIR STREQUAL ".")
-    list(APPEND LIT_ARGS --param build_mode=${CMAKE_CFG_INTDIR})
-  endif ()
 
   set(LIT_COMMAND "${Python_EXECUTABLE};${HERMES_LIT_PATH}")
   list(APPEND LIT_COMMAND ${LIT_ARGS})

test/lit.cfg

@@ -78,10 +78,11 @@ if isTrue(lit_config.params.get("exception_on_oom_enabled")):
 if lit_config.params.get("profiler") == "BB":
     config.available_features.add("basic_block_profiler")
 
-if lit_config.params.get("build_mode") != "opt":
+if isTrue(lit_config.params.get("slow_debug")):
+  config.available_features.add("slow_debug")
+
+if isTrue(lit_config.params.get("debug_options")):
   config.available_features.add("debug_options")
-  if lit_config.params.get("build_mode") == "dbg":
-    config.available_features.add("slow_debug")
 
 if lit_config.params.get("gc") == "MALLOC":
   config.available_features.add("gc_malloc")