Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProtocolBench Build Rules #620

Closed
lukalt opened this issue Sep 10, 2024 · 1 comment
Closed

ProtocolBench Build Rules #620

lukalt opened this issue Sep 10, 2024 · 1 comment

Comments

@lukalt
Copy link

lukalt commented Sep 10, 2024

The provided build scripts lack rules for building ProtocolBench (https://github.com/facebook/fbthrift/blob/main/thrift/lib/cpp2/test/ProtocolBench.cpp) and it is not intuitive how to build it manually.

I tried building it with a handcrafted
CMakeLists.txt after compiling some thrift files:

cd /fbthrift/thrift/lib/cpp2/test && thrift1 -I /fbthrift/ --gen mstch_cpp2:frozen2 ProtocolBenchmark.thrift
cd /fbthrift/thrift/lib/cpp2/test && thrift1 -I /fbthrift/ --gen mstch_cpp2:frozen2 ProtocolBenchData.thrift
cd /fbthrift/thrift/lib/thrift && for x in *.thrift; do thrift1 -I /fbthrift/ --gen mstch_cpp2:frozen2 $x; done
cd /fbthrift/thrift/conformance/if && for x in *.thrift; do thrift1 -I /fbthrift/ --gen mstch_cpp2:frozen2 $x; done

I ran into a couple link errors (see cmake_output.txt) and are unable to resolve them myself.

Could you please provide instructions on how to build ProtocolBench. It would be really helpful to have cmake rules provided inside the repository for that.

@lukalt
Copy link
Author

lukalt commented Nov 5, 2024

Fixed in #626

@lukalt lukalt closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant