Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac CI artifacts should link to provided libraries using @rpath or relative paths, not fixed paths in /usr/local/ #435

Open
fredemmott opened this issue Jul 1, 2021 · 0 comments

Comments

@fredemmott
Copy link
Contributor

For example:

fredemmott@fredemmott-fbmbp bin % otool -L thrift1
thrift1:
	/usr/local/lib/libssl.1.1.dylib (compatibility version 1.1.0, current version 1.1.0)
	/usr/local/lib/libcrypto.1.1.dylib (compatibility version 1.1.0, current version 1.1.0)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 902.1.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1281.100.1)

Those libraries in /usr/local/lib are not present, and can not be safely installed without interfering with system software (so homebrew refuses to use them)

Fortunately, they're included in the lib directory of this artifact, but they have the same problem:

fredemmott@fredemmott-fbmbp lib % otool -L libssl.1.1.dylib
libssl.1.1.dylib:
	libssl.1.1.dylib (compatibility version 1.1.0, current version 1.1.0)
	/usr/local/lib/libcrypto.1.1.dylib (compatibility version 1.1.0, current version 1.1.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1281.100.1)

Ideally CMake would link these with relative or rpath, but install_name_tool can be used to fix these up after the fact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant